Skip to content

Commit 4dbaaf9

Browse files
committed
changes from review
1 parent f4faadc commit 4dbaaf9

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

GoogleSignIn/Sources/GIDAuthStateMigration.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
static NSString *const kDataProtectedMigrationCheckPerformedKey =
3434
@"GID_DataProtectedMigrationCheckPerformed";
3535

36-
3736
// Keychain account used to store additional state in SDKs previous to v5, including GPPSignIn.
3837
static NSString *const kOldKeychainAccount = @"GooglePlus";
3938

@@ -97,7 +96,7 @@ - (void)performDataProtectedMigrationIfNeeded {
9796
if ([defaults boolForKey:kDataProtectedMigrationCheckPerformedKey]) {
9897
return;
9998
}
100-
// Migrate from the fileBasedKeychain to dataProtectedKeychain with GTMAppAuth 5.0.
99+
101100
GTMKeychainAttribute *fileBasedKeychain = [GTMKeychainAttribute useFileBasedKeychain];
102101
NSSet *attributes = [NSSet setWithArray:@[fileBasedKeychain]];
103102
GTMKeychainStore *keychainStoreLegacy =

GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ - (void)testMigrateIfNeeded_KeychainFailure_DataProtectedMigration {
185185
}
186186

187187
#else
188-
189188
- (void)testMigrateIfNeeded_NoPreviousMigration_GTMAppAuthMigration {
190189
[[[_mockUserDefaults stub] andReturn:_mockUserDefaults] standardUserDefaults];
191190
[[[_mockUserDefaults expect] andReturnValue:@NO] boolForKey:kGTMAppAuthMigrationCheckPerformedKey];

0 commit comments

Comments
 (0)