Skip to content

Commit 7e76eae

Browse files
committed
More cleanup.
1 parent 89649b1 commit 7e76eae

File tree

1 file changed

+3
-19
lines changed

1 file changed

+3
-19
lines changed

GoogleSignIn/Tests/Unit/GIDSignInTest.m

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -228,23 +228,9 @@ @interface GIDSignInTest : XCTestCase {
228228
// The configuration to be used when testing `GIDSignIn`.
229229
GIDConfiguration *_configuration;
230230

231-
// The login hint to be used when testing `GIDSignIn`.
232-
NSString *_hint;
233-
234231
// The completion to be used when testing `GIDSignIn`.
235232
GIDSignInCompletion _completion;
236233

237-
#if TARGET_OS_IOS || TARGET_OS_MACCATALYST
238-
// The saved presentingViewController from the authorization request.
239-
UIViewController *_savedPresentingViewController;
240-
#elif TARGET_OS_OSX
241-
// The saved presentingWindow from the authorization request.
242-
NSWindow *_savedPresentingWindow;
243-
#endif // TARGET_OS_IOS || TARGET_OS_MACCATALYST
244-
245-
// The saved authorization callback.
246-
OIDAuthorizationCallback _savedAuthorizationCallback;
247-
248234
// The saved token request.
249235
OIDTokenRequest *_savedTokenRequest;
250236

@@ -308,8 +294,6 @@ - (void)setUp {
308294
profileDataFetcher:_profileDataFetcher
309295
authorizationFlowProcessor:_authorizationFlowProcessor];
310296

311-
_hint = nil;
312-
313297
__weak GIDSignInTest *weakSelf = self;
314298
_completion = ^(GIDSignInResult *_Nullable signInResult, NSError * _Nullable error) {
315299
GIDSignInTest *strongSelf = weakSelf;
@@ -772,7 +756,7 @@ - (void)testPresentingViewControllerException {
772756
#elif TARGET_OS_OSX
773757
XCTAssertThrows([_signIn signInWithPresentingWindow:_presentingWindow
774758
#endif // TARGET_OS_IOS || TARGET_OS_MACCATALYST
775-
hint:_hint
759+
hint:nil
776760
completion:_completion]);
777761
}
778762

@@ -807,7 +791,7 @@ - (void)testSchemesNotSupportedException {
807791
#elif TARGET_OS_OSX
808792
[_signIn signInWithPresentingWindow:_presentingWindow
809793
#endif // TARGET_OS_IOS || TARGET_OS_MACCATALYST
810-
hint:_hint
794+
hint:nil
811795
completion:_completion];
812796
} @catch (NSException *exception) {
813797
threw = YES;
@@ -1107,7 +1091,7 @@ - (void)OAuthLoginWithAddScopesFlow:(BOOL)addScopesFlow
11071091
#elif TARGET_OS_OSX
11081092
[_signIn signInWithPresentingWindow:_presentingWindow
11091093
#endif // TARGET_OS_IOS || TARGET_OS_MACCATALYST
1110-
hint:_hint
1094+
hint:nil
11111095
completion:completion];
11121096
}
11131097

0 commit comments

Comments
 (0)