Skip to content

Commit eade6df

Browse files
authored
Allow GTMSessionFetcher 3.x (#257)
1 parent 46c6dc7 commit eade6df

File tree

6 files changed

+18
-41
lines changed

6 files changed

+18
-41
lines changed

GoogleSignIn.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ The Google Sign-In SDK allows users to sign in with their Google account from th
1212
:git => 'https://github.com/google/GoogleSignIn-iOS.git',
1313
:tag => s.version.to_s
1414
}
15-
ios_deployment_target = '9.0'
15+
ios_deployment_target = '10.0'
1616
osx_deployment_target = '10.15'
1717
s.ios.deployment_target = ios_deployment_target
1818
s.osx.deployment_target = osx_deployment_target
@@ -33,8 +33,8 @@ The Google Sign-In SDK allows users to sign in with their Google account from th
3333
s.ios.framework = 'UIKit'
3434
s.osx.framework = 'AppKit'
3535
s.dependency 'AppAuth', '~> 1.5'
36-
s.dependency 'GTMAppAuth', '~> 1.3'
37-
s.dependency 'GTMSessionFetcher/Core', '>= 1.1', '< 3.0'
36+
s.dependency 'GTMAppAuth', '>= 1.3', '< 3.0'
37+
s.dependency 'GTMSessionFetcher/Core', '>= 1.1', '< 4.0'
3838
s.resource_bundle = {
3939
'GoogleSignIn' => ['GoogleSignIn/Sources/{Resources,Strings}/*']
4040
}

GoogleSignIn/Sources/GIDEMMErrorHandler.m

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -267,13 +267,7 @@ - (UIAlertController *)appVerificationRequiredAlertWithURL:(nullable NSURL *)url
267267
}
268268

269269
- (void)openURL:(NSURL *)url {
270-
if (@available(iOS 10, *)) {
271-
[UIApplication.sharedApplication openURL:url options:@{} completionHandler:nil];
272-
} else {
273-
#if __IPHONE_OS_VERSION_MIN_REQUIRED < __IPHONE_10_0
274-
[UIApplication.sharedApplication openURL:url];
275-
#endif // __IPHONE_OS_VERSION_MIN_REQUIRED < __IPHONE_10_0
276-
}
270+
[UIApplication.sharedApplication openURL:url options:@{} completionHandler:nil];
277271
}
278272

279273
#pragma mark - Localization

GoogleSignIn/Tests/Unit/GIDEMMErrorHandlerTest.m

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,7 @@ - (void)expectOpenURLString:(NSString *)urlString inAction:(void (^)(void))actio
114114
selector:@selector(sharedApplication)
115115
isClassSelector:YES
116116
withBlock:^() { return mockApplication; }];
117-
if (@available(iOS 10, *)) {
118-
[[mockApplication expect] openURL:[NSURL URLWithString:urlString] options:@{} completionHandler:nil];
119-
} else {
120-
[[mockApplication expect] openURL:[NSURL URLWithString:urlString]];
121-
}
117+
[[mockApplication expect] openURL:[NSURL URLWithString:urlString] options:@{} completionHandler:nil];
122118
action();
123119
[mockApplication verify];
124120
[GULSwizzler unswizzleClass:[UIApplication class]

Package.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ let package = Package(
2424
defaultLocalization: "en",
2525
platforms: [
2626
.macOS(.v10_15),
27-
.iOS(.v9)
27+
.iOS(.v10)
2828
],
2929
products: [
3030
.library(
@@ -48,11 +48,11 @@ let package = Package(
4848
.package(
4949
name: "GTMAppAuth",
5050
url: "https://github.com/google/GTMAppAuth.git",
51-
"1.3.0" ..< "2.0.0"),
51+
"1.3.0" ..< "3.0.0"),
5252
.package(
5353
name: "GTMSessionFetcher",
5454
url: "https://github.com/google/gtm-session-fetcher.git",
55-
"1.5.0" ..< "3.0.0"),
55+
"1.5.0" ..< "4.0.0"),
5656
.package(
5757
name: "OCMock",
5858
url: "https://github.com/firebase/ocmock.git",

Samples/ObjC/SignInSample/SignInSample.xcodeproj/project.pbxproj

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
objects = {
88

99
/* Begin PBXBuildFile section */
10+
C1D4BC8A2926EF61001BCB24 /* GoogleSignIn in Frameworks */ = {isa = PBXBuildFile; productRef = C1D4BC892926EF61001BCB24 /* GoogleSignIn */; };
1011
C1E69232264315E7004CE2BC /* SignInViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = C1E69226264315E7004CE2BC /* SignInViewController.m */; };
1112
C1E69233264315E7004CE2BC /* LaunchScreen.xib in Resources */ = {isa = PBXBuildFile; fileRef = C1E69228264315E7004CE2BC /* LaunchScreen.xib */; };
1213
C1E69234264315E7004CE2BC /* DataPickerState.m in Sources */ = {isa = PBXBuildFile; fileRef = C1E6922A264315E7004CE2BC /* DataPickerState.m */; };
@@ -15,7 +16,6 @@
1516
C1E69237264315E7004CE2BC /* SignInViewController.xib in Resources */ = {isa = PBXBuildFile; fileRef = C1E6922D264315E7004CE2BC /* SignInViewController.xib */; };
1617
C1E69238264315E7004CE2BC /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = C1E6922F264315E7004CE2BC /* AppDelegate.m */; };
1718
C1E69239264315E7004CE2BC /* AuthInspectorViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = C1E69231264315E7004CE2BC /* AuthInspectorViewController.m */; };
18-
C1E6924426431A6D004CE2BC /* GoogleSignIn in Frameworks */ = {isa = PBXBuildFile; productRef = C1E6924326431A6D004CE2BC /* GoogleSignIn */; };
1919
C1E6927C26431E13004CE2BC /* Dummy.strings in Resources */ = {isa = PBXBuildFile; fileRef = C1E6925326431E12004CE2BC /* Dummy.strings */; };
2020
C1E6927D26431E13004CE2BC /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = C1E6926E26431E13004CE2BC /* Images.xcassets */; };
2121
C1E6927E26431E13004CE2BC /* DataPickerDictionary.plist in Resources */ = {isa = PBXBuildFile; fileRef = C1E6927026431E13004CE2BC /* DataPickerDictionary.plist */; };
@@ -92,7 +92,7 @@
9292
isa = PBXFrameworksBuildPhase;
9393
buildActionMask = 2147483647;
9494
files = (
95-
C1E6924426431A6D004CE2BC /* GoogleSignIn in Frameworks */,
95+
C1D4BC8A2926EF61001BCB24 /* GoogleSignIn in Frameworks */,
9696
);
9797
runOnlyForDeploymentPostprocessing = 0;
9898
};
@@ -188,7 +188,7 @@
188188
);
189189
name = SignInSample;
190190
packageProductDependencies = (
191-
C1E6924326431A6D004CE2BC /* GoogleSignIn */,
191+
C1D4BC892926EF61001BCB24 /* GoogleSignIn */,
192192
);
193193
productName = SignInSample;
194194
productReference = D99924CA1A92B3C7008CC226 /* SignInSample.app */;
@@ -253,7 +253,6 @@
253253
);
254254
mainGroup = D99924C11A92B3C7008CC226;
255255
packageReferences = (
256-
C1E6924226431A6D004CE2BC /* XCRemoteSwiftPackageReference "GoogleSignIn-iOS" */,
257256
);
258257
productRefGroup = D99924CB1A92B3C7008CC226 /* Products */;
259258
projectDirPath = "";
@@ -392,7 +391,7 @@
392391
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
393392
GCC_WARN_UNUSED_FUNCTION = YES;
394393
GCC_WARN_UNUSED_VARIABLE = YES;
395-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
394+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
396395
MTL_ENABLE_DEBUG_INFO = YES;
397396
ONLY_ACTIVE_ARCH = YES;
398397
OTHER_LDFLAGS = "-ObjC";
@@ -442,7 +441,7 @@
442441
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
443442
GCC_WARN_UNUSED_FUNCTION = YES;
444443
GCC_WARN_UNUSED_VARIABLE = YES;
445-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
444+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
446445
MTL_ENABLE_DEBUG_INFO = NO;
447446
OTHER_LDFLAGS = "-ObjC";
448447
SDKROOT = iphoneos;
@@ -510,21 +509,9 @@
510509
};
511510
/* End XCConfigurationList section */
512511

513-
/* Begin XCRemoteSwiftPackageReference section */
514-
C1E6924226431A6D004CE2BC /* XCRemoteSwiftPackageReference "GoogleSignIn-iOS" */ = {
515-
isa = XCRemoteSwiftPackageReference;
516-
repositoryURL = "https://github.com/google/GoogleSignIn-iOS.git";
517-
requirement = {
518-
branch = main;
519-
kind = branch;
520-
};
521-
};
522-
/* End XCRemoteSwiftPackageReference section */
523-
524512
/* Begin XCSwiftPackageProductDependency section */
525-
C1E6924326431A6D004CE2BC /* GoogleSignIn */ = {
513+
C1D4BC892926EF61001BCB24 /* GoogleSignIn */ = {
526514
isa = XCSwiftPackageProductDependency;
527-
package = C1E6924226431A6D004CE2BC /* XCRemoteSwiftPackageReference "GoogleSignIn-iOS" */;
528515
productName = GoogleSignIn;
529516
};
530517
/* End XCSwiftPackageProductDependency section */

Samples/ObjC/SignInSample/SignInSampleForPod.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@
433433
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
434434
GCC_WARN_UNUSED_FUNCTION = YES;
435435
GCC_WARN_UNUSED_VARIABLE = YES;
436-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
436+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
437437
MTL_ENABLE_DEBUG_INFO = YES;
438438
ONLY_ACTIVE_ARCH = YES;
439439
SDKROOT = iphoneos;
@@ -483,7 +483,7 @@
483483
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
484484
GCC_WARN_UNUSED_FUNCTION = YES;
485485
GCC_WARN_UNUSED_VARIABLE = YES;
486-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
486+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
487487
MTL_ENABLE_DEBUG_INFO = NO;
488488
SDKROOT = iphoneos;
489489
TARGETED_DEVICE_FAMILY = "1,2";
@@ -497,7 +497,7 @@
497497
buildSettings = {
498498
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
499499
INFOPLIST_FILE = "$(SRCROOT)/SignInSample-Info.plist";
500-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
500+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
501501
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
502502
PRODUCT_BUNDLE_IDENTIFIER = com.google.SignInSample;
503503
PRODUCT_NAME = SignInSample;
@@ -510,7 +510,7 @@
510510
buildSettings = {
511511
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
512512
INFOPLIST_FILE = "$(SRCROOT)/SignInSample-Info.plist";
513-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
513+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
514514
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
515515
PRODUCT_BUNDLE_IDENTIFIER = com.google.SignInSample;
516516
PRODUCT_NAME = SignInSample;

0 commit comments

Comments
 (0)