Skip to content

adkrest server controller panic when llm generate returns error #383

@byebyebruce

Description

@byebyebruce

Describe the bug
adkrest server controller panic when llm generate returns error

To Reproduce
Is continue correct? or maybe return?

// server/adkrest/controllers/runtime.go

	resp := r.Run(req.Context(), runAgentRequest.UserId, runAgentRequest.SessionId, &runAgentRequest.NewMessage, *rCfg)

	rw.WriteHeader(http.StatusOK)
	for event, err := range resp {
		if err != nil {
			_, err := fmt.Fprintf(rw, "Error while running agent: %v\n", err)
			if err != nil {
				return newStatusError(fmt.Errorf("write response: %w", err), http.StatusInternalServerError)
			}
			flusher.Flush()
			continue
		}
		err := flashEvent(flusher, rw, *event)
		if err != nil {
			return err
		}
	}
	return nil
}
Image

Expected behavior
No panic

Screenshots

Image

Desktop (please complete the following information):

  • OS: [macOS]
  • Go version: go version go1.24.9 darwin/arm64
  • ADK version: v0.2.0

Model Information:

  • openai gpt-5.1(adapted model )

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions