bug: Move ToolContext#listArtifacts() in the parent CallbackContext #326
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @glaforge, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've refactored the Java codebase to improve consistency with its Python counterpart regarding artifact service methods. Specifically, I've moved the listArtifacts() method from ToolContext to CallbackContext, consolidating all artifact-related operations within CallbackContext for better organization and alignment.
Highlights
- Method Relocation: The
listArtifacts()method has been moved fromToolContexttoCallbackContext. - API Alignment: This change aligns the Java context classes with the Python implementation, where artifact service methods reside in the callback context.
- Code Organization: All artifact-related methods (
listArtifacts(),loadArtifact(),saveArtifact()) are now co-located withinCallbackContext.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the listArtifacts() method by moving it from ToolContext to its parent class CallbackContext. This change improves the API design by grouping all artifact-related methods together, aligning the Java code with its Python counterpart as intended. My review includes a suggestion to improve consistency within CallbackContext and a more critical point about updating the corresponding unit tests to reflect this refactoring.
|
Please fix the formatting and then commit history and then we're good to mark this as ready to pull |
|
Formatting and commit history should be fixed now, sorry! |
Poggecci
left a comment
Poggecci
left a comment
There was a problem hiding this comment.
Thank you for this change
2 participants
Fixes #325
In Python, the methods on contexts to handle the artifact service are on the callback_context class.
But somehow, in Java, the listArtifacts() method was in ToolContext instead, whereas, oddly, loadArtifact() and saveArtifact() were in CallbackContext.
That way, we align Java and Python, and bring listArtifacts() with the other artifact methods.