fix: Make FunctionTool slightly more null safe, and use Text Blocks #485
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces minor but significant refinements to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several small but useful changes to the FunctionTool class. The use of text blocks for multi-line strings improves readability, and the changes to use type annotations for @Nullable and equals() on string literals for null-safety are good practices. I've included a couple of minor suggestions to further improve the code style and consistency.
This is in anticipation of doing more work in this class in the context of google#473; it just makes it easier to working on and raising more changes, and these automagic changes propose by VSC actually do make sense, instead of having to "fight your IDE" to undo this when working on this class.
vorburger
force-pushed
the
issue-473_FunctionTool-clean
branch
from
9c1f7ea to
a2295a3
Compare
2 participants
This is in anticipation of doing more work in this class in the context of #473; it just makes it easier to working on and raising more changes, and these automagic changes propose by VSC actually do make sense, instead of having to "fight your IDE" to undo this when working on this class.