Skip to content

Commit 3b80337

Browse files
jawoszekcopybara-github
authored andcommitted
feat(otel): temporarily disable Cloud Monitoring integration in --otel_to_cloud
Currently there is chance for Cloud Monitoring-related errors in logs during shutdown. Let's disable metrics part until it is fixed. PiperOrigin-RevId: 808930635
1 parent d4eaa06 commit 3b80337

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/google/adk/cli/adk_web_server.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,8 @@ def _setup_telemetry_experimental(
306306
# TODO - use trace_to_cloud here as well once otel_to_cloud is no
307307
# longer experimental.
308308
enable_cloud_tracing=True,
309-
enable_cloud_metrics=True,
309+
# TODO - reenable metrics once errors during shutdown are fixed.
310+
enable_cloud_metrics=False,
310311
enable_cloud_logging=True,
311312
)
312313
)
@@ -501,8 +502,8 @@ def get_fast_api_app(
501502
tear_down_observer: Callback for cleaning up the file system observer.
502503
register_processors: Callback for additional Span processors to be added
503504
to the TracerProvider.
504-
otel_to_cloud: EXPERIMENTAL. Whether to enable Cloud Trace,
505-
Cloud Monitoring and Cloud Logging integrations.
505+
otel_to_cloud: EXPERIMENTAL. Whether to enable Cloud Trace
506+
and Cloud Logging integrations.
506507
507508
Returns:
508509
A FastAPI app instance.

src/google/adk/cli/cli_tools_click.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -815,8 +815,7 @@ def decorator(func):
815815
default=False,
816816
help=(
817817
"EXPERIMENTAL Optional. Whether to write OTel data to Google Cloud"
818-
" Observability services - Cloud Trace, Cloud Monitoring and Cloud"
819-
" Logging."
818+
" Observability services - Cloud Trace and Cloud Logging."
820819
),
821820
)
822821
@click.option(

0 commit comments

Comments
 (0)