Skip to content

Commit a2b7909

Browse files
DeanChensjcopybara-github
authored andcommitted
fix: Fix the packaging version comparison logic in adk cli
Resolves #2503 PiperOrigin-RevId: 795519711
1 parent b66054d commit a2b7909

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/google/adk/cli/cli_deploy.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from typing import Optional
2020

2121
import click
22+
from packaging.version import parse
2223

2324
_DOCKERFILE_TEMPLATE = """
2425
FROM python:3.11-slim
@@ -91,7 +92,8 @@ def _get_service_option_by_adk_version(
9192
memory_uri: Optional[str],
9293
) -> str:
9394
"""Returns service option string based on adk_version."""
94-
if adk_version >= '1.3.0':
95+
parsed_version = parse(adk_version)
96+
if parsed_version >= parse('1.3.0'):
9597
session_option = (
9698
f'--session_service_uri={session_uri}' if session_uri else ''
9799
)
@@ -100,7 +102,7 @@ def _get_service_option_by_adk_version(
100102
)
101103
memory_option = f'--memory_service_uri={memory_uri}' if memory_uri else ''
102104
return f'{session_option} {artifact_option} {memory_option}'
103-
elif adk_version >= '1.2.0':
105+
elif parsed_version >= parse('1.2.0'):
104106
session_option = f'--session_db_url={session_uri}' if session_uri else ''
105107
artifact_option = (
106108
f'--artifact_storage_uri={artifact_uri}' if artifact_uri else ''

0 commit comments

Comments
 (0)