feat: passthrough extra args for adk deploy cloud_run as Cloud Run args
#2544
+451
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Response from ADK Triaging Agent Hello @jackwotherspoon, thank you for creating this PR! To help us review this PR, could you please address the following from our contribution guidelines:
You can find more details in our contribution guidelines. This information will help reviewers to review your PR more efficiently. Thanks! |
|
Please add testing plan(log or screenshot) |
|
Response from ADK Triaging Agent Hello @jackwotherspoon, thank you for updating the PR with a testing plan! Before this can be reviewed, could you please address the following:
You can find more details in our contribution guidelines. These changes are needed before the reviewers can proceed. Thank you! |
adk-bot
added
bot triaged
hangfei
reviewed
Aug 15, 2025
|
@jackwotherspoon I see there is a merge conflict, could you help resolve? |
Jacksunwei
reviewed
Aug 15, 2025
Jacksunwei
approved these changes
Aug 25, 2025
Jacksunwei
added
the
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
…args Merge #2544 The command `adk deploy cloud_run` supports limited `gcloud run deploy` args 😢. Which makes the command fine for simple deployments... It should support all current and future Cloud Run deployment args for the command to be widely adopted. This can easily be done by passing through all extra args passed to `adk deploy cloud_run` to gcloud... This PR assumes any extra args/flags passed after `AGENT_PATH` are gcloud flags. ## Example ```sh # ADK flags adk deploy cloud_run \ --project=$GOOGLE_CLOUD_PROJECT \ --region=$GOOGLE_CLOUD_LOCATION \ $AGENT_PATH \ # Use the -- separator for gcloud args -- \ --min-instances=2 \ --no-allow-unauthenticated ``` This gives full Cloud Run feature support to ADK users 🤖 🚀 ## Test Plan To test you can just build locally or pip install feature branch directly: ``` uv venv uv pip install git+https://github.com/jackwotherspoon/adk-python.git ``` Deploy to Cloud Run using additional arguments following `AGENT_PATH`, such as `--min-instance=2` or `--description="Cloud Run test"`: ```sh uv run adk deploy cloud_run \ --project=$GOOGLE_CLOUD_PROJECT \ --region=$GOOGLE_CLOUD_LOCATION \ --with_ui \ $AGENT_PATH \ -- \ --labels=test-label=adk \ --min-instances=2 ``` You can click on the Cloud Run service after deployment and check the service yaml, you should see the additional label etc. <img width="1612" height="622" alt="image" src="https://github.com/user-attachments/assets/596a260a-0052-460b-9642-c18900ccf7c9" /> Fixes #2351 COPYBARA_INTEGRATE_REVIEW=#2544 from jackwotherspoon:main 184a4d7 PiperOrigin-RevId: 799252544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
adk deploy cloud_runsupports limitedgcloud run deployargs 😢.Which makes the command fine for simple deployments...
It should support all current and future Cloud Run deployment args for the command to be widely adopted.
This can easily be done by passing through all extra args passed to
adk deploy cloud_runto gcloud...This PR assumes any extra args/flags passed after
AGENT_PATHare gcloud flags.Example
This gives full Cloud Run feature support to ADK users 🤖 🚀
Test Plan
To test you can just build locally or pip install feature branch directly:
Deploy to Cloud Run using additional arguments following
AGENT_PATH, such as--min-instance=2or--description="Cloud Run test":You can click on the Cloud Run service after deployment and check the service yaml, you should see the additional label etc.
Fixes #2351