Skip to content

Commit 039c011

Browse files
committed
Move metrics protos outside of the cuttlefish directory
This will simplify the internal import script. Bug: b/446052689
1 parent e46e6e8 commit 039c011

File tree

12 files changed

+25
-24
lines changed

12 files changed

+25
-24
lines changed

base/cvd/cuttlefish/host/commands/cvd/cli/commands/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,12 +401,12 @@ cf_cc_library(
401401
"//cuttlefish/host/commands/cvd/metrics:is_enabled",
402402
"//cuttlefish/host/commands/cvd/utils",
403403
"//cuttlefish/host/commands/metrics:libmetrics_utils",
404-
"//cuttlefish/host/commands/metrics/proto:cf_log_cc_proto",
405-
"//cuttlefish/host/commands/metrics/proto:clientanalytics_cc_proto",
406-
"//cuttlefish/host/commands/metrics/proto:log_source_enum_cc_proto",
407404
"//cuttlefish/host/libs/config:config_constants",
408405
"//cuttlefish/host/libs/config:cuttlefish_config",
409406
"//cuttlefish/host/libs/metrics:metrics_headers",
407+
"//external_proto:cf_log_cc_proto",
408+
"//external_proto:clientanalytics_cc_proto",
409+
"//external_proto:log_source_enum_cc_proto",
410410
"//libbase",
411411
"@fmt",
412412
],

base/cvd/cuttlefish/host/commands/cvd/cli/commands/start.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@
6565
#include "cuttlefish/host/commands/cvd/utils/common.h"
6666
#include "cuttlefish/host/commands/cvd/utils/interrupt_listener.h"
6767
#include "cuttlefish/host/commands/cvd/utils/subprocess_waiter.h"
68-
#include "cuttlefish/host/commands/metrics/proto/cf_log.pb.h"
69-
#include "cuttlefish/host/commands/metrics/proto/clientanalytics.pb.h"
70-
#include "cuttlefish/host/commands/metrics/proto/log_source_enum.pb.h"
7168
#include "cuttlefish/host/commands/metrics/utils.h"
7269
#include "cuttlefish/host/libs/config/config_constants.h"
7370
#include "cuttlefish/host/libs/config/cuttlefish_config.h"
7471
#include "cuttlefish/host/libs/metrics/metrics_defs.h"
72+
#include "external_proto/cf_log.pb.h"
73+
#include "external_proto/clientanalytics.pb.h"
74+
#include "external_proto/log_source_enum.pb.h"
7575

7676
namespace cuttlefish {
7777
namespace {

base/cvd/cuttlefish/host/commands/metrics/BUILD.bazel

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ cf_cc_binary(
1919
"//cuttlefish/common/libs/utils:files",
2020
"//cuttlefish/common/libs/utils:flag_parser",
2121
"//cuttlefish/common/libs/utils:tee_logging",
22-
"//cuttlefish/host/commands/metrics/proto:cf_log_cc_proto",
23-
"//cuttlefish/host/commands/metrics/proto:cf_metrics_event_cc_proto",
24-
"//cuttlefish/host/commands/metrics/proto:clientanalytics_cc_proto",
25-
"//cuttlefish/host/commands/metrics/proto:log_source_enum_cc_proto",
2622
"//cuttlefish/host/libs/config:cuttlefish_config",
2723
"//cuttlefish/host/libs/config:vmm_mode",
2824
"//cuttlefish/host/libs/metrics",
2925
"//cuttlefish/host/libs/metrics:metrics_headers",
3026
"//cuttlefish/host/libs/msg_queue",
27+
"//external_proto:cf_log_cc_proto",
28+
"//external_proto:cf_metrics_event_cc_proto",
29+
"//external_proto:clientanalytics_cc_proto",
30+
"//external_proto:log_source_enum_cc_proto",
3131
"//libbase",
3232
"@fruit",
3333
"@gflags",
@@ -43,12 +43,12 @@ cf_cc_library(
4343
hdrs = ["utils.h"],
4444
deps = [
4545
"//cuttlefish/common/libs/utils:tee_logging",
46-
"//cuttlefish/host/commands/metrics/proto:clientanalytics_cc_proto",
4746
"//cuttlefish/host/libs/metrics:metrics_headers",
4847
"//cuttlefish/host/libs/web/http_client",
4948
"//cuttlefish/host/libs/web/http_client:curl_global_init",
5049
"//cuttlefish/host/libs/web/http_client:curl_http_client",
5150
"//cuttlefish/host/libs/web/http_client:http_string",
51+
"//external_proto:clientanalytics_cc_proto",
5252
"//libbase",
5353
"@gflags",
5454
],

base/cvd/cuttlefish/host/commands/metrics/events.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@
2121

2222
#include "cuttlefish/common/libs/utils/files.h"
2323
#include "cuttlefish/common/libs/utils/flag_parser.h"
24-
#include "cuttlefish/host/commands/metrics/proto/cf_log.pb.h"
25-
#include "cuttlefish/host/commands/metrics/proto/cf_metrics_event.pb.h"
26-
#include "cuttlefish/host/commands/metrics/proto/clientanalytics.pb.h"
27-
#include "cuttlefish/host/commands/metrics/proto/log_source_enum.pb.h"
2824
#include "cuttlefish/host/commands/metrics/utils.h"
2925
#include "cuttlefish/host/libs/config/cuttlefish_config.h"
3026
#include "cuttlefish/host/libs/config/vmm_mode.h"
3127
#include "cuttlefish/host/libs/metrics/metrics_defs.h"
28+
#include "external_proto/cf_log.pb.h"
29+
#include "external_proto/cf_metrics_event.pb.h"
30+
#include "external_proto/clientanalytics.pb.h"
31+
#include "external_proto/log_source_enum.pb.h"
3232

3333
namespace cuttlefish {
3434

base/cvd/cuttlefish/host/commands/metrics/events.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
*/
1616
#pragma once
1717

18-
#include "cuttlefish/host/commands/metrics/proto/cf_log.pb.h"
19-
#include "cuttlefish/host/commands/metrics/proto/cf_metrics_event.pb.h"
18+
#include "external_proto/cf_log.pb.h"
19+
#include "external_proto/cf_metrics_event.pb.h"
2020

2121
namespace cuttlefish {
2222

base/cvd/cuttlefish/host/commands/metrics/host_receiver.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@
2020
#include <android-base/logging.h>
2121

2222
#include "cuttlefish/host/commands/metrics/events.h"
23-
#include "cuttlefish/host/commands/metrics/proto/cf_log.pb.h"
2423
#include "cuttlefish/host/libs/metrics/metrics_configs.h"
2524
#include "cuttlefish/host/libs/metrics/metrics_defs.h"
2625
#include "cuttlefish/host/libs/metrics/metrics_receiver.h"
2726
#include "cuttlefish/host/libs/msg_queue/msg_queue.h"
27+
#include "external_proto/cf_log.pb.h"
2828

2929
namespace cuttlefish {
3030

base/cvd/cuttlefish/host/commands/metrics/utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
*/
1616
#pragma once
1717

18-
#include "cuttlefish/host/commands/metrics/proto/clientanalytics.pb.h"
1918
#include "cuttlefish/host/libs/metrics/metrics_defs.h"
2019
#include "cuttlefish/host/libs/web/http_client/http_client.h"
20+
#include "external_proto/clientanalytics.pb.h"
2121

2222
namespace cuttlefish::metrics {
2323

base/cvd/cuttlefish/host/commands/metrics/proto/BUILD.bazel renamed to base/cvd/external_proto/BUILD.bazel

File renamed without changes.

base/cvd/cuttlefish/host/commands/metrics/proto/cf_log.proto renamed to base/cvd/external_proto/cf_log.proto

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ syntax = "proto2";
1717

1818
package logs.proto.wireless.android.cuttlefish;
1919

20-
import "cuttlefish/host/commands/metrics/proto/cf_metrics_event.proto";
20+
import "external_proto/cf_metrics_event.proto";
2121
import "google/protobuf/timestamp.proto";
2222

2323
// Wrapper for Cuttlefish log events
@@ -28,14 +28,14 @@ message CuttlefishLogEvent {
2828
// Next index: 3
2929
enum DeviceType {
3030
// The log event was sourced from an unspecified device type.
31-
//TODO(moelsherif) : This event is not converted yet in the code
31+
// TODO(moelsherif) : This event is not converted yet in the code
3232
CUTTLEFISH_DEVICE_TYPE_UNSPECIFIED = 0;
3333

3434
// A log event that was sourced from a Cuttlefish host device.
3535
CUTTLEFISH_DEVICE_TYPE_HOST = 1;
3636

3737
// A log event that was sent by an Cuttlefish guest device.
38-
//TODO(moelsherif) : This event is not converted yet in the code
38+
// TODO(moelsherif) : This event is not converted yet in the code
3939
CUTTLEFISH_DEVICE_TYPE_GUEST = 2;
4040
}
4141

base/cvd/cuttlefish/host/commands/metrics/proto/cf_metrics_event.proto renamed to base/cvd/external_proto/cf_metrics_event.proto

File renamed without changes.

0 commit comments

Comments
 (0)