Rename --extract_super_image_fragments to --dynamic_super_image

This better describes the intended behavioral difference. The flag will
enable a breaking change that assumes to-be-implemented behavior in
`assemble_cvd` that will create the super image on-demand.

Test: bazel run //cuttlefish/package:cvd -- fetch --dynamic_super_image=true

Author: Databean

base/cvd/cuttlefish/host/commands/cvd/fetch/download_flags.cc

@@ -27,9 +27,8 @@ DownloadFlags DownloadFlags::Create(const VectorFlags& flags, const int index) {
       .download_target_files_zip =
           GetOptional(flags.download_target_files_zip, index)
               .value_or(kDefaultDownloadTargetFilesZip),
-      .extract_super_image_fragments =
-          GetOptional(flags.extract_super_image_fragments, index)
-              .value_or(kDefaultExtractSuperImageFragments),
+      .dynamic_super_image = GetOptional(flags.dynamic_super_image, index)
+                                 .value_or(kDefaultDynamicSuperImageFragments),
   };
 }
 

base/cvd/cuttlefish/host/commands/cvd/fetch/download_flags.h

@@ -24,7 +24,7 @@ struct DownloadFlags {
 
   bool download_img_zip;
   bool download_target_files_zip;
-  bool extract_super_image_fragments;
+  bool dynamic_super_image;
 };
 
 }  // namespace cuttlefish

base/cvd/cuttlefish/host/commands/cvd/fetch/fetch_cvd.cc

@@ -219,7 +219,7 @@ Result<void> FetchDefaultTarget(FetchBuildContext& context,
         fmt::format("default/{}", target_files_name);
     CF_EXPECT(target_files.DownloadTo(download_location));
   }
-  if (flags.extract_super_image_fragments) {
+  if (flags.dynamic_super_image) {
     ReadableZip* target_files_zip = CF_EXPECT(target_files.AsZip());
     ReadableZipSource ab_partitions_source =
         CF_EXPECT(target_files_zip->GetFile("META/ab_partitions.txt"));

base/cvd/cuttlefish/host/commands/cvd/fetch/vector_flags.cc

@@ -69,10 +69,9 @@ std::vector<Flag> VectorFlags::Flags() {
                        kDefaultDownloadTargetFilesZip)
           .Help("Whether to fetch the -target_files-*.zip file."));
   flags.emplace_back(
-      GflagsCompatFlag("extract_super_image_fragments",
-                       this->extract_super_image_fragments,
-                       kDefaultExtractSuperImageFragments)
-          .Help("Whether to fetch the -target_files-*.zip file."));
+      GflagsCompatFlag("dynamic_super_image", this->dynamic_super_image,
+                       kDefaultDynamicSuperImageFragments)
+          .Help("Fetch the super image members as independent files."));
 
   return flags;
 }

base/cvd/cuttlefish/host/commands/cvd/fetch/vector_flags.h

@@ -28,7 +28,7 @@ namespace cuttlefish {
 inline constexpr bool kDefaultDownloadImgZip = true;
 inline constexpr bool kDefaultDownloadTargetFilesZip = false;
 // TODO: schuffelen - Enable this by default.
-inline constexpr bool kDefaultExtractSuperImageFragments = false;
+inline constexpr bool kDefaultDynamicSuperImageFragments = false;
 
 struct VectorFlags {
   std::vector<Flag> Flags();
@@ -46,7 +46,7 @@ struct VectorFlags {
   std::vector<bool> download_img_zip;
   std::vector<bool> download_target_files_zip;
   std::vector<std::string> boot_artifact;
-  std::vector<bool> extract_super_image_fragments;
+  std::vector<bool> dynamic_super_image;
 };
 
 }  // namespace cuttlefish