ms-tpm-20-ref: inline BUILD variables.

Use DAMP not DRY rules.

Bug: b/402294836

Author: jacky8hyf

base/cvd/BUILD.ms-tpm-20-ref.bazel

@@ -1,59 +1,6 @@
 load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
 load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
-# From PLATFORM_INC in TPMCmd/Makefile.am
-PLATFORM_INC = [
-    "TPMCmd/Platform/include",
-    "TPMCmd/Platform/include/prototypes",
-]
-
-# From SIMULATOR_INC in TPMCmd/Makefile.am
-SIMULATOR_INC = [
-    "TPMCmd/Simulator/include",
-    "TPMCmd/Simulator/include/prototypes",
-]
-
-# From TPM_INC in TPMCmd/Makefile.am
-TPM_INC = [
-    "TPMCmd/tpm/include",
-    "TPMCmd/tpm/include/platform_interface",
-    "TPMCmd/tpm/include/platform_interface/prototypes",
-    "TPMCmd/tpm/include/private",
-    "TPMCmd/tpm/include/private/prototypes",
-    "TPMCmd/tpm/include/public",
-    "TPMCmd/tpm/cryptolibs",
-    "TPMCmd/tpm/cryptolibs/common/include",
-    "TPMCmd/tpm/cryptolibs/Ossl/include",
-    "TPMCmd/tpm/cryptolibs/TpmBigNum/include",
-    "TPMCmd/TpmConfiguration",
-]
-
-# From configure.ac
-DEFINES = [
-    "HASH_LIB=Ossl",
-    "SYM_LIB=Ossl",
-    "MATH_LIB=TpmBigNum",
-    "BN_MATH_LIB=Ossl",
-]
-
-# From configure.ac
-COMPILER_FLAGS = [
-    "-std=gnu11",
-    "-Werror",
-    "-Wall",
-    "-Wformat-security",
-    "-fstack-protector-all",
-    "-fPIC",
-]
-
-# From configure.ac
-LINK_FLAGS = [
-    "-Wl,--no-undefined",
-    "-Wl,-z,noexecstack",
-    "-Wl,-z,now",
-    "-Wl,-z,relro",
-]
-
 # Use the provided configuration, plus patches in build_external/ms-tpm-20-ref.
 cc_library(
     name = "tpm_configuration",
@@ -65,15 +12,23 @@ cc_library(
 cc_library(
     name = "platform_headers",
     srcs = glob(["TPMCmd/Platform/**/*.h"]),
-    includes = PLATFORM_INC,
+    # From PLATFORM_INC in TPMCmd/Makefile.am
+    includes = [
+        "TPMCmd/Platform/include",
+        "TPMCmd/Platform/include/prototypes",
+    ],
     deps = [":tpm_configuration"],
 )
 
 # From SIMULATOR_H in bootstrap
 cc_library(
     name = "simulator_headers",
     srcs = glob(["TPMCmd/Simulator/**/*.h"]),
-    includes = SIMULATOR_INC,
+    # From SIMULATOR_INC in TPMCmd/Makefile.am
+    includes = [
+        "TPMCmd/Simulator/include",
+        "TPMCmd/Simulator/include/prototypes",
+    ],
 )
 
 # From TPM_H in bootstrap; added .inl files
@@ -83,14 +38,39 @@ cc_library(
         "TPMCmd/tpm/**/*.h",
         "TPMCmd/tpm/**/*.inl",
     ]),
-    includes = TPM_INC,
+    # From TPM_INC in TPMCmd/Makefile.am
+    includes = [
+        "TPMCmd/TpmConfiguration",
+        "TPMCmd/tpm/cryptolibs",
+        "TPMCmd/tpm/cryptolibs/Ossl/include",
+        "TPMCmd/tpm/cryptolibs/TpmBigNum/include",
+        "TPMCmd/tpm/cryptolibs/common/include",
+        "TPMCmd/tpm/include",
+        "TPMCmd/tpm/include/platform_interface",
+        "TPMCmd/tpm/include/platform_interface/prototypes",
+        "TPMCmd/tpm/include/private",
+        "TPMCmd/tpm/include/private/prototypes",
+        "TPMCmd/tpm/include/public",
+    ],
 )
 
 cc_library(
     name = "platform",
     srcs = glob(["TPMCmd/Platform/**/*.c"]),
-    copts = COMPILER_FLAGS,
-    defines = DEFINES,
+    copts = [
+        "-std=gnu11",
+        "-Werror",
+        "-Wall",
+        "-Wformat-security",
+        "-fstack-protector-all",
+        "-fPIC",
+    ],
+    defines = [
+        "HASH_LIB=Ossl",
+        "SYM_LIB=Ossl",
+        "MATH_LIB=TpmBigNum",
+        "BN_MATH_LIB=Ossl",
+    ],
     deps = [
         ":platform_headers",
         ":tpm_headers",
@@ -100,8 +80,20 @@ cc_library(
 cc_library(
     name = "tpm",
     srcs = glob(["TPMCmd/tpm/**/*.c"]),
-    copts = COMPILER_FLAGS,
-    defines = DEFINES,
+    copts = [
+        "-std=gnu11",
+        "-Werror",
+        "-Wall",
+        "-Wformat-security",
+        "-fstack-protector-all",
+        "-fPIC",
+    ],
+    defines = [
+        "HASH_LIB=Ossl",
+        "SYM_LIB=Ossl",
+        "MATH_LIB=TpmBigNum",
+        "BN_MATH_LIB=Ossl",
+    ],
     deps = [
         ":platform_headers",
         ":tpm_headers",
@@ -113,9 +105,26 @@ cc_library(
 cc_binary(
     name = "simulator",
     srcs = glob(["TPMCmd/Simulator/**/*.c"]),
-    copts = COMPILER_FLAGS,
-    defines = DEFINES,
-    linkopts = LINK_FLAGS,
+    copts = [
+        "-std=gnu11",
+        "-Werror",
+        "-Wall",
+        "-Wformat-security",
+        "-fstack-protector-all",
+        "-fPIC",
+    ],
+    defines = [
+        "HASH_LIB=Ossl",
+        "SYM_LIB=Ossl",
+        "MATH_LIB=TpmBigNum",
+        "BN_MATH_LIB=Ossl",
+    ],
+    linkopts = [
+        "-Wl,--no-undefined",
+        "-Wl,-z,noexecstack",
+        "-Wl,-z,now",
+        "-Wl,-z,relro",
+    ],
     visibility = ["//visibility:public"],
     deps = [
         ":platform",