Remove FetcherConfig::RecordFlags

This was more useful at a time when `fetch_cvd` used gflags. Also, it
has no callers.

Author: Databean

base/cvd/cuttlefish/host/libs/config/BUILD.bazel

@@ -192,7 +192,6 @@ cf_cc_library(
         "//cuttlefish/host/libs/config:file_source",
         "//libbase",
         "@abseil-cpp//absl/strings",
-        "@gflags",
         "@jsoncpp",
     ],
 )

base/cvd/cuttlefish/host/libs/config/fetcher_config.cpp

@@ -29,7 +29,6 @@
 #include <android-base/file.h>
 #include <android-base/logging.h>
 #include <android-base/strings.h>
-#include <gflags/gflags.h>
 #include <json/reader.h>
 #include <json/value.h>
 #include <json/writer.h>
@@ -44,7 +43,6 @@ namespace cuttlefish {
 
 namespace {
 
-const char* kFlags = "flags";
 const char* kCvdFiles = "cvd_files";
 const char* kCvdFileSource = "source";
 const char* kCvdFileBuildId = "build_id";
@@ -113,25 +111,6 @@ bool FetcherConfig::LoadFromFile(const std::string& file) {
   return true;
 }
 
-void FetcherConfig::RecordFlags() {
-  std::vector<gflags::CommandLineFlagInfo> all_flags;
-  GetAllFlags(&all_flags);
-  Json::Value flags_json(Json::arrayValue);
-  for (const auto& flag : all_flags) {
-    Json::Value flag_json;
-    flag_json["name"] = flag.name;
-    flag_json["type"] = flag.type;
-    flag_json["description"] = flag.description;
-    flag_json["current_value"] = flag.current_value;
-    flag_json["default_value"] = flag.default_value;
-    flag_json["filename"] = flag.filename;
-    flag_json["has_validator_fn"] = flag.has_validator_fn;
-    flag_json["is_default"] = flag.is_default;
-    flags_json.append(flag_json);
-  }
-  (*dictionary_)[kFlags] = flags_json;
-}
-
 namespace {
 
 CvdFile JsonToCvdFile(const std::string& file_path, const Json::Value& json) {

base/cvd/cuttlefish/host/libs/config/fetcher_config.h

@@ -69,9 +69,6 @@ class FetcherConfig {
   bool SaveToFile(const std::string& file) const;
   bool LoadFromFile(const std::string& file);
 
-  // For debugging only, not intended for programmatic access.
-  void RecordFlags();
-
   bool add_cvd_file(const CvdFile& file, bool override_entry = false);
   std::map<std::string, CvdFile> get_cvd_files() const;