Skip to content

Commit b8ac2db

Browse files
committed
Improve parser_names_test.cpp errors
Bug: b/389804379 Test: /usr/bin/bazel test '//...'
1 parent 12badff commit b8ac2db

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

base/cvd/cuttlefish/host/commands/cvd/unittests/selector/parser_names_helper.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
#include <optional>
1919
#include <string>
20-
#include <unordered_map>
21-
#include <unordered_set>
2220
#include <vector>
2321

2422
#include <gtest/gtest.h>

base/cvd/cuttlefish/host/commands/cvd/unittests/selector/parser_names_test.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,30 +16,33 @@
1616
#include <sys/types.h>
1717
#include <unistd.h>
1818

19+
#include "common/libs/utils/result_matchers.h"
1920
#include "host/commands/cvd/unittests/selector/parser_names_helper.h"
2021

2122
namespace cuttlefish {
2223
namespace selector {
2324

2425
TEST_P(ValidNamesTest, ValidInputs) {
2526
auto selector_options_res = ParseCommonSelectorArguments(selector_args_);
26-
ASSERT_TRUE(selector_options_res.ok());
27+
ASSERT_THAT(selector_options_res, IsOk());
28+
2729
auto parser = StartSelectorParser::ConductSelectFlagsParser(
2830
*selector_options_res, cvd_common::Args{}, cvd_common::Envs{});
2931

30-
ASSERT_TRUE(parser.ok());
32+
ASSERT_THAT(parser, IsOk());
3133
}
3234

3335
/**
3436
* Note that invalid inputs must be tested at the InstanceDatabase level
3537
*/
3638
TEST_P(ValidNamesTest, FieldsNoSubstring) {
3739
auto selector_options_res = ParseCommonSelectorArguments(selector_args_);
38-
ASSERT_TRUE(selector_options_res.ok());
40+
ASSERT_THAT(selector_options_res, IsOk());
41+
3942
auto parser = StartSelectorParser::ConductSelectFlagsParser(
4043
*selector_options_res, cvd_common::Args{}, cvd_common::Envs{});
4144

42-
ASSERT_TRUE(parser.ok());
45+
ASSERT_THAT(parser, IsOk());
4346
ASSERT_EQ(parser->GroupName(), expected_output_.group_name);
4447
ASSERT_EQ(parser->PerInstanceNames(), expected_output_.per_instance_names);
4548
}

0 commit comments

Comments
 (0)