Remove version-related fmtlib workarounds

fmtlib is now up to date in all places that build our source code.

Bug: b/445234045

Author: Databean

base/cvd/cuttlefish/common/libs/utils/result.h

@@ -27,16 +27,6 @@
 #include <android-base/logging.h>
 #include <android-base/result.h>  // IWYU pragma: export
 
-#if FMT_VERSION < 80000
-namespace fmt {
-  // fmt::runtime was added in v8.0.0
-  template<typename T>
-  const T& runtime(const T& param) {
-    return param;
-  }
-}
-#endif
-
 namespace cuttlefish {
 
 class StackTraceError;

base/cvd/cuttlefish/host/libs/config/external_network_mode.h

@@ -35,7 +35,5 @@ Result<ExternalNetworkMode> ParseExternalNetworkMode(std::string_view);
 
 }  // namespace cuttlefish
 
-#if FMT_VERSION >= 90000
 template <>
 struct fmt::formatter<cuttlefish::ExternalNetworkMode> : ostream_formatter {};
-#endif

base/cvd/cuttlefish/host/libs/config/vmm_mode.h

@@ -38,7 +38,5 @@ Result<VmmMode> ParseVmm(std::string_view);
 
 }  // namespace cuttlefish
 
-#if FMT_VERSION >= 90000
 template <>
 struct fmt::formatter<cuttlefish::VmmMode> : ostream_formatter {};
-#endif

base/cvd/cuttlefish/host/libs/web/chrome_os_build_string.h

@@ -23,13 +23,6 @@
 
 #include <fmt/format.h>
 
-#ifndef CONST_IF_LATER_FMTLIB
-#if FMT_VERSION >= 90000
-#define CONST_IF_LATER_FMTLIB const
-#else
-#define CONST_IF_LATER_FMTLIB
-#endif
-#endif
 #include "cuttlefish/common/libs/utils/flag_parser.h"
 
 namespace cuttlefish {
@@ -56,7 +49,7 @@ struct fmt::formatter<cuttlefish::ChromeOsBuilder>
     : formatter<std::string_view> {
   template <typename FormatContext>
   auto format(const cuttlefish::ChromeOsBuilder& cob,
-              FormatContext& ctx) CONST_IF_LATER_FMTLIB {
+              FormatContext& ctx) const {
     auto formatted =
         fmt::format("{}/{}/{}", cob.project, cob.bucket, cob.builder);
     return formatter<std::string_view>::format(formatted, ctx);
@@ -68,7 +61,7 @@ struct fmt::formatter<cuttlefish::ChromeOsBuildString>
     : formatter<std::string_view> {
   template <typename FormatContext>
   auto format(const cuttlefish::ChromeOsBuildString& cobs,
-              FormatContext& ctx) CONST_IF_LATER_FMTLIB {
+              FormatContext& ctx) const {
     auto formatted =
         std::visit([](auto&& value) { return fmt::format("{}", value); }, cobs);
     return formatter<std::string_view>::format(formatted, ctx);
@@ -80,7 +73,7 @@ struct fmt::formatter<std::optional<cuttlefish::ChromeOsBuildString>>
     : formatter<std::string_view> {
   template <typename FormatContext>
   auto format(const std::optional<cuttlefish::ChromeOsBuildString>& cobs,
-              FormatContext& ctx) CONST_IF_LATER_FMTLIB {
+              FormatContext& ctx) const {
     auto formatted = cobs ? fmt::format("{}", *cobs) : "";
     return formatter<std::string_view>::format(formatted, ctx);
   }