Skip to content

Commit c6e6682

Browse files
committed
Use absl::StrCat in ReadGuestConfig
Bug: b/472373911
1 parent 42dda3b commit c6e6682

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

base/cvd/cuttlefish/host/commands/assemble_cvd/guest_config.cc

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include <vector>
2424

2525
#include "absl/strings/match.h"
26+
#include "absl/strings/str_cat.h"
2627
#include "android-base/parseint.h"
2728
#include "fmt/format.h"
2829
#include "google/protobuf/io/zero_copy_stream_impl.h"
@@ -240,12 +241,12 @@ Result<void> ParseGuestConfigTxt(const std::string& guest_config_path,
240241

241242
Result<std::vector<GuestConfig>> ReadGuestConfig(
242243
const BootImageFlag& boot_image, const KernelPathFlag& kernel_path,
243-
const SystemImageDirFlag& system_image_dir) {
244+
const SystemImageDirFlag& system_image_dirs) {
244245
std::vector<GuestConfig> guest_configs;
245246

246247
const std::string env_path = fmt::format(
247248
"PATH={}:{}", StringFromEnv("PATH", ""), DefaultHostArtifactsPath("bin"));
248-
for (int instance_index = 0; instance_index < system_image_dir.Size();
249+
for (int instance_index = 0; instance_index < system_image_dirs.Size();
249250
instance_index++) {
250251
// extract-ikconfig can be called directly on the boot image since it looks
251252
// for the ikconfig header in the image before extracting the config list.
@@ -306,18 +307,21 @@ Result<std::vector<GuestConfig>> ReadGuestConfig(
306307
(guest_config.android_version_number != "13");
307308
}
308309

310+
const std::string sys_img_dir = system_image_dirs.ForIndex(instance_index);
311+
309312
constexpr char kGuestConfigFilename[] = "cuttlefish-guest-config.txtpb";
313+
310314
const std::string guest_config_path =
311-
system_image_dir.ForIndex(instance_index) + "/" + kGuestConfigFilename;
315+
absl::StrCat(sys_img_dir, "/", kGuestConfigFilename);
312316
if (FileExists(guest_config_path)) {
313317
CF_EXPECT(ParseGuestConfigTextProto(guest_config_path, guest_config));
314318
} else {
315319
const std::string android_info_txt_path =
316-
system_image_dir.ForIndex(instance_index) + "/android-info.txt";
320+
absl::StrCat(sys_img_dir, "/android-info.txt");
317321
CF_EXPECT(ParseGuestConfigTxt(android_info_txt_path, guest_config));
318322
}
319323

320-
guest_configs.push_back(guest_config);
324+
guest_configs.push_back(std::move(guest_config));
321325
}
322326
return guest_configs;
323327
}

0 commit comments

Comments
 (0)