-
Notifications
You must be signed in to change notification settings - Fork 316
Fixed to prevent checkbox crashes#2661 #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmanojkmr
wants to merge
9
commits into
google:master
Choose a base branch
from
mmanojkmr:mk_master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9954d2d
Fixed to prevent checkbox crashes#2661
mmanojkmr 5ba34f3
Fixed to prevent checkbox crashes#2661
mmanojkmr b5cb073
SpotlessApply
mmanojkmr 1519577
set repeat value true
mmanojkmr 2cff3e3
FHIR questionnaire attachment item shows as 'not answered' in review …
mmanojkmr c3eef16
CHeckbox Crashes #2661
mmanojkmr 2a99140
seprated 2790 issue
mmanojkmr 999ab1b
file updated
mmanojkmr 848f9c9
code updated
mmanojkmr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| /* | ||
| * Copyright 2023-2024 Google LLC | ||
| * Copyright 2023-2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
|
|
@@ -616,4 +616,51 @@ class CheckBoxGroupViewHolderFactoryTest { | |
| }, | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun click_should_Select_Other_CheckboxButton() { | ||
| viewHolder.bind( | ||
| QuestionnaireViewItem( | ||
| Questionnaire.QuestionnaireItemComponent().apply { | ||
| repeats = false | ||
| addAnswerOption( | ||
| Questionnaire.QuestionnaireItemAnswerOptionComponent().apply { | ||
| value = | ||
| Coding().apply { | ||
| code = "code-1" | ||
| display = "display-1" | ||
| } | ||
| }, | ||
| ) | ||
| addAnswerOption( | ||
| Questionnaire.QuestionnaireItemAnswerOptionComponent().apply { | ||
| value = | ||
| Coding().apply { | ||
| code = "code-2" | ||
| display = "display-2" | ||
| } | ||
| }, | ||
| ) | ||
| }, | ||
| QuestionnaireResponse.QuestionnaireResponseItemComponent().apply { | ||
| addAnswer( | ||
| QuestionnaireResponse.QuestionnaireResponseItemAnswerComponent().apply { | ||
| value = | ||
| Coding().apply { | ||
| code = "code-1" | ||
| display = "display-1" | ||
| } | ||
| }, | ||
| ) | ||
| }, | ||
| validationResult = NotValidated, | ||
| answersChangedCallback = { _, _, _, _ -> }, | ||
| ), | ||
| ) | ||
|
|
||
| val checkBoxGroup = viewHolder.itemView.findViewById<ConstraintLayout>(R.id.checkbox_group) | ||
| assertThat((checkBoxGroup.getChildAt(1) as CheckBox).isChecked).isTrue() | ||
| checkBoxGroup.getChildAt(2).performClick() | ||
| assertThat((checkBoxGroup.getChildAt(2) as CheckBox).isChecked).isTrue() | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check here that the first answer is not selected. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add |
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.