Skip to content

Commit 947997a

Browse files
HuYuxinAngle LUCI CQ
authored andcommitted
Fix convertLowpAndMediumpFloatUniformsTo16Bits condition
The convertLowpAndMediumpFloatUniformsTo16Bits feature relies on the following vulkan features to be enabled when creating the VkDevice through vkCreateDevice(): VkPhysicalDevice16BitStorageFeatures.uniformAndStorageBuffer16BitAccess, VkPhysicalDeviceShaderFloat16Int8Features.shaderFloat16 Previously we are checking if these vulkan features are supported, this CL changed the condition to check if these vulkan features will actually be enabled on the VkDevice created. Bug: angleproject:405795981 Change-Id: I6c46d5982b7e793f5d0326cf6c1cb5afa3a9d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7164378 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 parent b863743 commit 947997a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/libANGLE/renderer/vulkan/vk_renderer.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6584,9 +6584,8 @@ void Renderer::initFeatures(const vk::ExtensionNameList &deviceExtensionNames,
65846584
// Disable on driver implementations other than ARM proprietary until the performance impact on
65856585
// them is verified.
65866586
ANGLE_FEATURE_CONDITION(&mFeatures, convertLowpAndMediumpFloatUniformsTo16Bits,
6587-
m16BitStorageFeatures.uniformAndStorageBuffer16BitAccess == VK_TRUE &&
6588-
mShaderFloat16Int8Features.shaderFloat16 == VK_TRUE &&
6589-
isARMProprietary);
6587+
mFeatures.supports16BitUniformAndStorageBuffer.enabled &&
6588+
mFeatures.supportsShaderFloat16.enabled && isARMProprietary);
65906589

65916590
ANGLE_FEATURE_CONDITION(&mFeatures, supportsUnifiedImageLayouts,
65926591
mUnifiedImageLayoutsFeatures.unifiedImageLayouts == VK_TRUE);

0 commit comments

Comments
 (0)