Skip to content

Commit a0e36ad

Browse files
lexaknyazevAngle LUCI CQ
authored andcommitted
Vulkan: Fix image bindings for non-layered textures
Layer index must be ignored if the texture does not have multiple layers or faces. Fixed: angleproject:344950165 Change-Id: I4b402ee28d365f0459f980e01488828c80c93527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185849 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
1 parent 8bf7d45 commit a0e36ad

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

src/libANGLE/renderer/vulkan/TextureVk.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3817,7 +3817,9 @@ angle::Result TextureVk::getStorageImageView(vk::Context *context,
38173817
getNativeImageLevel(gl::LevelIndex(static_cast<uint32_t>(binding.level)));
38183818
vk::LevelIndex nativeLevelVk = mImage->toVkLevel(nativeLevelGL);
38193819

3820-
if (binding.layered != GL_TRUE)
3820+
// If the texture does not have multiple layers or faces, the entire texture
3821+
// level is bound, regardless of the values specified by layered and layer.
3822+
if (binding.layered != GL_TRUE && IsLayeredTextureType(mState.getType()))
38213823
{
38223824
uint32_t nativeLayer = getNativeImageLayer(static_cast<uint32_t>(binding.layer));
38233825

src/tests/angle_end2end_tests_expectations.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1218,9 +1218,6 @@ b/330697097 PIXEL6 VULKAN : FramebufferTest_ES31.MultisampleResolveBothAttachmen
12181218
42264522 PIXEL4ORXL VULKAN : ComputeShaderTest.SSBOAliasOverWrite/* = SKIP
12191219
b/266235549 D3D11 : ComputeShaderTest.SSBOAliasOverWrite/* = SKIP
12201220

1221-
// Incorrect image binding in Vulkan backend
1222-
344950165 VULKAN : TextureTestES31.Texture2DLayered/* = SKIP
1223-
12241221
// Samsung Galaxy S22 (Xclipse)
12251222
b/267953710 GALAXYS22 GLES : VulkanImageTest.DeviceVulkan/* = SKIP
12261223
b/267953710 GALAXYS22 GLES : VulkanImageTest.HasVulkanImageExtensions/* = SKIP

src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,3 @@ b/328156792 PINEAPPLE VULKAN : KHR-GLES31.core.texture_cube_map_array* = SKIP
379379
379700129 PIXEL4ORXL VULKAN : KHR-GLES31.core.texture_stencil8.multisample = SKIP
380380
379700129 PIXEL6 VULKAN : KHR-GLES31.core.texture_stencil8.multisample = SKIP
381381
379700129 GALAXYS22 VULKAN : KHR-GLES31.core.texture_stencil8.multisample = SKIP
382-
383-
// New test in VK-GL-CTS roll 2024-12-27
384-
386087992 VULKAN : KHR-GLES31.core.bind_image_texture.single_layer = SKIP

0 commit comments

Comments
 (0)