Vulkan: Disable clipCullDistance ext if GS/TS

  The extension GL_EXT_clip_cull_distance also interacts with geometry
and tessellation shaders. These features are currently in development.

* Added temporary flag: supportsClipCullDistanceInGSAndTS
  * Currently disabled by default
  * clipCullDistanceEXT can only be enabled if this feature is enabled,
    or if the device does not support geometry or tessellation shaders.
  * After the features become available, this flag can be removed.

Bug: angleproject:42264006
Bug: b/415288635
Change-Id: Iac5c672fd980710519407c482bc95d2b0019aea2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6795025
Reviewed-by: Shahbaz Youssefi <[email protected]>
Commit-Queue: Amirali Abdolrashidi <[email protected]>

Author: aabdolrashidi

include/platform/autogen/FeaturesVk_autogen.h

@@ -1496,6 +1496,12 @@ struct FeaturesVk : FeatureSetBase
         &members,
     };
 
+    FeatureInfo supportsClipCullDistanceInGSAndTS = {
+        "supportsClipCullDistanceInGSAndTS",
+        FeatureCategory::VulkanFeatures,
+        &members,
+    };
+
     FeatureInfo supportsMaintenance9 = {
         "supportsMaintenance9",
         FeatureCategory::VulkanFeatures,

include/platform/vk_features.json

@@ -1968,6 +1968,14 @@
             ],
             "issue": "http://anglebug.com/386688871"
         },
+        {
+            "name": "supports_clip_cull_distance_in_GS_and_TS",
+            "category": "Features",
+            "description": [
+                "Supports using clip/cull distance features in geometry and tessellation shaders"
+            ],
+            "issue": "http://anglebug.com/42264006"
+        },
         {
             "name": "supports_maintenance9",
             "category": "Features",

src/libANGLE/renderer/vulkan/vk_caps_utils.cpp

@@ -1267,7 +1267,9 @@ void Renderer::ensureCapsInitialized() const
     // After implementing EXT_geometry_shader, EXT_clip_cull_distance should be additionally
     // implemented to support the geometry shader. Until then, EXT_clip_cull_distance is enabled
     // only in the experimental cases.
-    if (mPhysicalDeviceFeatures.shaderClipDistance &&
+    if ((mFeatures.supportsClipCullDistanceInGSAndTS.enabled ||
+         (!mNativeExtensions.geometryShaderAny() && !mNativeExtensions.tessellationShaderAny())) &&
+        mPhysicalDeviceFeatures.shaderClipDistance &&
         limitsVk.maxClipDistances >= kMaxClipDistancePerSpec)
     {
         // Do not enable GL_APPLE_clip_distance for Samsung devices.

src/libANGLE/renderer/vulkan/vk_renderer.cpp

@@ -6174,6 +6174,11 @@ void Renderer::initFeatures(const vk::ExtensionNameList &deviceExtensionNames,
         &mFeatures, supportsUniformBufferStandardLayout,
         mUniformBufferStandardLayoutFeatures.uniformBufferStandardLayout == VK_TRUE);
 
+    // http://anglebug.com/42264006
+    // GL_EXT_clip_cull_distance also adds features to geometry and tessellation shaders, which are
+    // currently disabled.
+    ANGLE_FEATURE_CONDITION(&mFeatures, supportsClipCullDistanceInGSAndTS, false);
+
     // Disable memory report feature overrides if extension is not supported.
     if ((mFeatures.logMemoryReportCallbacks.enabled || mFeatures.logMemoryReportStats.enabled) &&
         !mMemoryReportFeatures.deviceMemoryReport)

util/autogen/angle_features_autogen.cpp

@@ -312,6 +312,7 @@ constexpr PackedEnumMap<Feature, const char *> kFeatureNames = {{
     {Feature::SupportsBindMemory2, "supportsBindMemory2"},
     {Feature::SupportsBlendOperationAdvanced, "supportsBlendOperationAdvanced"},
     {Feature::SupportsBlendOperationAdvancedCoherent, "supportsBlendOperationAdvancedCoherent"},
+    {Feature::SupportsClipCullDistanceInGSAndTS, "supportsClipCullDistanceInGSAndTS"},
     {Feature::SupportsColorWriteEnable, "supportsColorWriteEnable"},
     {Feature::SupportsComputeTranscodeEtcToBc, "supportsComputeTranscodeEtcToBc"},
     {Feature::SupportsCustomBorderColor, "supportsCustomBorderColor"},

util/autogen/angle_features_autogen.h

@@ -312,6 +312,7 @@ enum class Feature
     SupportsBindMemory2,
     SupportsBlendOperationAdvanced,
     SupportsBlendOperationAdvancedCoherent,
+    SupportsClipCullDistanceInGSAndTS,
     SupportsColorWriteEnable,
     SupportsComputeTranscodeEtcToBc,
     SupportsCustomBorderColor,