CL: Pass in memory properties from cl entry point

The spec requires the valid properties to be reported as by
`clGetMemObjectInfo()`. So pass in the properties as is post their
validation.

Bug: angleproject:378017028
Change-Id: I8b7ddc9d0e71ea56b2f8d81764fc3a21cee6bef4
Signed-off-by: Gowtham Tammana <[email protected]>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6004684
Reviewed-by: Geoff Lang <[email protected]>
Reviewed-by: Shahbaz Youssefi <[email protected]>

Author: gowtham-sarc

src/libANGLE/CLContext.cpp

@@ -120,7 +120,23 @@ cl_mem Context::createBuffer(const cl_mem_properties *properties,
                              size_t size,
                              void *hostPtr)
 {
-    return Object::Create<Buffer>(*this, Memory::PropArray{}, flags, size, hostPtr);
+    // If the properties argument specified in clCreateBufferWithProperties or
+    // clCreateImageWithProperties used to create memobj was not NULL, the implementation must
+    // return the values specified in the properties argument in the same order and without
+    // including additional properties. So pass them as is.
+    Memory::PropArray propArray;
+    if (properties != nullptr)
+    {
+        const cl_mem_properties *propIt = properties;
+        while (*propIt != 0)
+        {
+            propArray.push_back(*propIt);
+            ++propIt;
+        }
+        // there is at least one property - special property 0
+        propArray.push_back(0);
+    }
+    return Object::Create<Buffer>(*this, std::move(propArray), flags, size, hostPtr);
 }
 
 cl_mem Context::createImage(const cl_mem_properties *properties,
@@ -129,11 +145,33 @@ cl_mem Context::createImage(const cl_mem_properties *properties,
                             const cl_image_desc *desc,
                             void *hostPtr)
 {
-    const ImageDescriptor imageDesc(FromCLenum<MemObjectType>(desc->image_type), desc->image_width,
-                                    desc->image_height, desc->image_depth, desc->image_array_size,
-                                    desc->image_row_pitch, desc->image_slice_pitch,
-                                    desc->num_mip_levels, desc->num_samples);
-    return Object::Create<Image>(*this, Memory::PropArray{}, flags, *format, imageDesc,
+    const ImageDescriptor imageDesc = {FromCLenum<MemObjectType>(desc->image_type),
+                                       desc->image_width,
+                                       desc->image_height,
+                                       desc->image_depth,
+                                       desc->image_array_size,
+                                       desc->image_row_pitch,
+                                       desc->image_slice_pitch,
+                                       desc->num_mip_levels,
+                                       desc->num_samples};
+    Memory::PropArray propArray;
+
+    // If the properties argument specified in clCreateBufferWithProperties or
+    // clCreateImageWithProperties used to create memobj was not NULL, the implementation must
+    // return the values specified in the properties argument in the same order and without
+    // including additional properties. So Pass them as is.
+    if (properties != nullptr)
+    {
+        const cl_mem_properties *propIt = properties;
+        while (*propIt != 0)
+        {
+            propArray.push_back(*propIt);
+            ++propIt;
+        }
+        // there is at least one property - special property 0
+        propArray.push_back(0);
+    }
+    return Object::Create<Image>(*this, std::move(propArray), flags, *format, imageDesc,
                                  Memory::Cast(desc->buffer), hostPtr);
 }