Skip to content

Commit 64ae5ea

Browse files
committed
Refactor Ecdsa SigningKey with template arguments
EcdsaSigningKey is takes curve size and hash as template arguments PiperOrigin-RevId: 354631278 Change-Id: Iae504801c5f542b34b7a1b3257ea9deeed7ab34b
1 parent 859d84b commit 64ae5ea

File tree

7 files changed

+1861
-1350
lines changed

7 files changed

+1861
-1350
lines changed

asylo/crypto/BUILD

Lines changed: 38 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -567,11 +567,9 @@ cc_library(
567567
)
568568

569569
cc_library(
570-
name = "ecdsa_p256_sha256_signing_key",
571-
srcs = ["ecdsa_p256_sha256_signing_key.cc"],
572-
hdrs = ["ecdsa_p256_sha256_signing_key.h"],
573-
copts = ASYLO_DEFAULT_COPTS,
574-
visibility = ["//asylo:implementation"],
570+
name = "ecdsa_signing_key",
571+
srcs = ["ecdsa_signing_key.cc"],
572+
hdrs = ["ecdsa_signing_key.h"],
575573
deps = [
576574
":algorithms_cc_proto",
577575
":bignum_util",
@@ -590,12 +588,13 @@ cc_library(
590588
],
591589
)
592590

593-
cc_test(
594-
name = "ecdsa_p256_sha256_signing_key_test",
595-
srcs = ["ecdsa_p256_sha256_signing_key_test.cc"],
596-
copts = ASYLO_DEFAULT_COPTS,
591+
cc_library(
592+
name = "ecdsa_signing_key_test",
593+
testonly = True,
594+
hdrs = ["ecdsa_signing_key_test.h"],
597595
deps = [
598-
":ecdsa_p256_sha256_signing_key",
596+
":algorithms_cc_proto",
597+
":ecdsa_signing_key",
599598
":fake_signing_key",
600599
":keys_cc_proto",
601600
":signing_key",
@@ -604,17 +603,45 @@ cc_test(
604603
"//asylo/test/util:proto_matchers",
605604
"//asylo/test/util:status_matchers",
606605
"//asylo/test/util:string_matchers",
607-
"//asylo/test/util:test_main",
608606
"//asylo/util:cleansing_types",
609607
"//asylo/util:logging",
610608
"@boringssl//:crypto",
611609
"@com_google_absl//absl/flags:flag",
610+
"@com_google_absl//absl/functional:bind_front",
612611
"@com_google_absl//absl/strings",
613612
"@com_google_googletest//:gtest",
614613
"@com_google_protobuf//:protobuf",
615614
],
616615
)
617616

617+
cc_library(
618+
name = "ecdsa_p256_sha256_signing_key",
619+
hdrs = ["ecdsa_p256_sha256_signing_key.h"],
620+
copts = ASYLO_DEFAULT_COPTS,
621+
visibility = ["//asylo:implementation"],
622+
deps = [
623+
":algorithms_cc_proto",
624+
":ecdsa_signing_key",
625+
":sha256_hash",
626+
"@boringssl//:crypto",
627+
],
628+
)
629+
630+
cc_test(
631+
name = "ecdsa_p256_sha256_signing_key_test",
632+
srcs = ["ecdsa_p256_sha256_signing_key_test.cc"],
633+
copts = ASYLO_DEFAULT_COPTS,
634+
deps = [
635+
":algorithms_cc_proto",
636+
":ecdsa_p256_sha256_signing_key",
637+
":ecdsa_signing_key_test",
638+
"//asylo/crypto/util:byte_container_view",
639+
"//asylo/test/util:test_main",
640+
"@com_google_absl//absl/strings",
641+
"@com_google_googletest//:gtest",
642+
],
643+
)
644+
618645
cc_library(
619646
name = "fake_certificate",
620647
testonly = 1,

0 commit comments

Comments
 (0)