Skip to content

Commit e07b747

Browse files
committed
Raise error for unknown args.
Fix #348
1 parent 684c503 commit e07b747

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

efficientdet/main.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,9 @@
120120

121121

122122
def main(argv):
123-
del argv # Unused.
123+
assert len(argv) >= 1
124+
if len(argv) > 1: # Do not accept unknown args.
125+
raise ValueError('Received unknown arguments: {}'.format(argv[1:]))
124126

125127
if FLAGS.use_tpu:
126128
tpu_cluster_resolver = tf.distribute.cluster_resolver.TPUClusterResolver(

efficientdet/model_inspect.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,11 @@ def run_model(self, runmode, **kwargs):
435435
trace_filename=kwargs.get('trace_filename', None))
436436

437437

438-
def main(_):
438+
def main(argv):
439+
assert len(argv) >= 1
440+
if len(argv) > 1: # Do not accept unknown args.
441+
raise ValueError('Received unknown arguments: {}'.format(argv[1:]))
442+
439443
if tf.io.gfile.exists(FLAGS.logdir) and FLAGS.delete_logdir:
440444
logging.info('Deleting log dir ...')
441445
tf.io.gfile.rmtree(FLAGS.logdir)

0 commit comments

Comments
 (0)