Fix bug: link Shlwapi in Libs.private for Windows (#1996)

xshthkr · web-flow · commit 1b721bbeff04 · 2025-06-06T15:15:56.000+01:00
* link Shlwapi in Libs.private for Windows

* Add self as contributor
diff --git a/AUTHORS b/AUTHORS
@@ -63,6 +63,7 @@ Rainer Orth <ro@cebitec.uni-bielefeld.de>
 Roman Lebedev <lebedev.ri@gmail.com>
 Sayan Bhattacharjee <aero.sayan@gmail.com>
 Shapr3D <google-contributors@shapr3d.com>
+Shashank Thakur <shashankt2004@gmail.com>
 Shuo Chen <chenshuo@chenshuo.com>
 Staffan Tjernstrom <staffantj@gmail.com>
 Steinar H. Gunderson <sgunderson@bigfoot.com>
diff --git a/CONTRIBUTORS b/CONTRIBUTORS
@@ -89,6 +89,7 @@ Ray Glover <ray.glover@uk.ibm.com>
 Robert Guo <robert.guo@mongodb.com>
 Roman Lebedev <lebedev.ri@gmail.com>
 Sayan Bhattacharjee <aero.sayan@gmail.com>
+Shashank Thakur <shashankt2004@gmail.com>
 Shuo Chen <chenshuo@chenshuo.com>
 Steven Wan <wan.yu@ibm.com>
 Tobias Schmidt <tobias.schmidt@in.tum.de>
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -62,6 +62,7 @@ endif(HAVE_LIB_RT)
 # We need extra libraries on Windows
 if(${CMAKE_SYSTEM_NAME} MATCHES "Windows")
   target_link_libraries(benchmark PRIVATE shlwapi)
+  set(BENCHMARK_PRIVATE_LINK_LIBRARIES -lShlwapi)
 endif()
 
 # We need extra libraries on Solaris

-Original file line number
+Diff line change
 Roman Lebedev <[email protected]>
 Sayan Bhattacharjee <[email protected]>
 Shapr3D <[email protected]>
 +Shashank Thakur <[email protected]>
 Shuo Chen <[email protected]>
 Staffan Tjernstrom <[email protected]>
 Steinar H. Gunderson <[email protected]>