Re-enable presubmit linting

* Update to golangci 1.48.0
* Re-enable linting

Signed-off-by: David Porter <[email protected]>

Author: bobbypage

.golangci.yml

@@ -39,6 +39,8 @@ issues:
     - "(method|func) [A-Z].* should be .*"
 #   Stuttering affects exported names:
     - "type name will be used as .*\\.[A-Z]{1}.* by other packages, and that stutters"
+#   TODO: Migrate away from io/ioutil
+    - "\"io/ioutil\" has been deprecated since Go 1.16"
   exclude-rules:
 #   utils/cpuload/netlink/netlink.go:102:15: Error return value of `binary.Write` is not checked (errcheck)
 #   There are more similar issues in this file

Makefile

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 GO := go
-GOLANGCI_VER := v1.45.2
+GOLANGCI_VER := v1.48.0
 GO_TEST ?= $(GO) test $(or $(GO_FLAGS),-race)
 arch ?= $(shell go env GOARCH)
 
@@ -74,7 +74,7 @@ docker-%:
 docker-build:
 	@docker run --rm -w /go/src/github.com/google/cadvisor -v ${PWD}:/go/src/github.com/google/cadvisor golang:1.18 make build
 
-presubmit: # lint : TODO re-enable lint after it works on golang 1.19
+presubmit: lint
 	@echo ">> checking go mod tidy"
 	@./build/check_gotidy.sh
 	@echo ">> checking file boilerplate"

cmd/cadvisor.go

@@ -228,7 +228,7 @@ func createCollectorHTTPClient(collectorCert, collectorKey string) http.Client {
 		}
 
 		tlsConfig.Certificates = []tls.Certificate{cert}
-		tlsConfig.BuildNameToCertificate()
+		tlsConfig.BuildNameToCertificate() //nolint: staticcheck
 	}
 
 	transport := &http.Transport{