Skip to content

Commit 2ae3a68

Browse files
committed
Drop DockerInfo/DockerImages in favor of directly using methods
Signed-off-by: Davanum Srinivas <[email protected]>
1 parent bae1093 commit 2ae3a68

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

cmd/internal/pages/docker.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ func serveDockerPage(m manager.Manager, w http.ResponseWriter, u *url.URL) {
7878
}
7979

8080
// Get Docker status
81-
status, err := m.DockerInfo()
81+
status, err := docker.Status()
8282
if err != nil {
8383
http.Error(w, fmt.Sprintf("failed to get docker info: %v", err), http.StatusInternalServerError)
8484
return
8585
}
8686

8787
dockerStatus, driverStatus := toStatusKV(status)
8888
// Get Docker Images
89-
images, err := m.DockerImages()
89+
images, err := docker.Images()
9090
if err != nil {
9191
http.Error(w, fmt.Sprintf("failed to get docker images: %v", err), http.StatusInternalServerError)
9292
return

manager/manager.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,6 @@ type Manager interface {
134134

135135
CloseEventChannel(watchID int)
136136

137-
// Get status information about docker.
138-
DockerInfo() (info.DockerStatus, error)
139-
140-
// Get details about interesting docker images.
141-
DockerImages() ([]info.DockerImage, error)
142-
143137
// Returns debugging information. Map of lines per category.
144138
DebugInfo() map[string][]string
145139
}
@@ -1335,14 +1329,6 @@ func parseEventsStoragePolicy() events.StoragePolicy {
13351329
return policy
13361330
}
13371331

1338-
func (m *manager) DockerImages() ([]info.DockerImage, error) {
1339-
return docker.Images()
1340-
}
1341-
1342-
func (m *manager) DockerInfo() (info.DockerStatus, error) {
1343-
return docker.Status()
1344-
}
1345-
13461332
func (m *manager) DebugInfo() map[string][]string {
13471333
debugInfo := container.DebugInfo()
13481334

0 commit comments

Comments
 (0)