Makefile: install golangci-lint if not found

Check if golangci-lint is available locally -- if not, install it
to GOPATH/bin. This helps with cases when golangci-lint is not
available on the host (such as in prow).

As we now have golangci-lint installation in Makefile, remove the
code installing it from .github/workflows/test.yml for better
maintainability.

While at it, add lint to .PHONY targets.

Signed-off-by: Kir Kolyshkin <[email protected]>

Author: kolyshkin

.github/workflows/test.yml

@@ -2,8 +2,6 @@ name: Test
 on: [push, pull_request]
 jobs:
   lint:
-    env:
-      GOLANGCI_LINT_V: 1.34.1
     strategy:
       matrix:
         environment-variables: [build/config/plain.sh, build/config/libpfm4.sh, build/config/libipmctl.sh]
@@ -14,14 +12,6 @@ jobs:
       uses: actions/setup-go@v2
       with:
         go-version: 1.17
-    - name: Install golangci-lint
-      run: >
-        cd /tmp &&
-        mkdir -p $(go env GOPATH)/bin &&
-        wget -q https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_LINT_V}/golangci-lint-${GOLANGCI_LINT_V}-linux-amd64.tar.gz &&
-        tar xf golangci-lint-${GOLANGCI_LINT_V}-linux-amd64.tar.gz &&
-        mv golangci-lint-${GOLANGCI_LINT_V}-linux-amd64/golangci-lint $(go env GOPATH)/bin &&
-        rm -fr golangci-lint-*
     - name: Checkout code
       uses: actions/checkout@v2
     - name: Run golangci-lint

Makefile

@@ -13,10 +13,10 @@
 # limitations under the License.
 
 GO := go
+GOLANGCI_VER := v1.42.1
 pkgs     = $(shell $(GO) list ./... | grep -v vendor)
 cmd_pkgs = $(shell cd cmd && $(GO) list ./... | grep -v vendor)
 arch ?= $(shell go env GOARCH)
-go_path = $(shell go env GOPATH)
 
 ifeq ($(arch), amd64)
   Dockerfile_tag := ''
@@ -97,10 +97,15 @@ presubmit: vet
 	@./build/check_boilerplate.sh
 
 lint:
+	@# This assumes GOPATH/bin is in $PATH -- if not, the target will fail.
+	@if ! golangci-lint version; then \
+		echo ">> installing golangci-lint $(GOLANGCI_VER)"; \
+		curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $$(go env GOPATH)/bin $(GOLANGCI_VER); \
+	fi
 	@echo ">> running golangci-lint using configuration at .golangci.yml"
-	@GOFLAGS="$(GO_FLAGS)" $(go_path)/bin/golangci-lint run
+	@golangci-lint run
 
 clean:
 	@rm -f *.test cadvisor
 
-.PHONY: all build docker format release test test-integration vet presubmit tidy
+.PHONY: all build docker format release test test-integration vet lint presubmit tidy