cmd: address staticcheck linter warnings

These ones:

internal/storage/statsd/client/client.go:50:12: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
	_, err := fmt.Fprintf(c.conn, formatted)
	          ^
internal/storage/bigquery/client/client.go:74:38: SA1019: oauth2.NoContext is deprecated: Use context.Background() or context.TODO() instead. (staticcheck)
	token, err := jwtConfig.TokenSource(oauth2.NoContext).Token()
	                                    ^
internal/storage/bigquery/client/client.go:91:26: SA1019: oauth2.NoContext is deprecated: Use context.Background() or context.TODO() instead. (staticcheck)
	client := config.Client(oauth2.NoContext, token)
	                        ^
internal/storage/bigquery/client/client.go:93:18: SA1019: bigquery.New is deprecated: please use NewService instead. To provide a custom HTTP client, use option.WithHTTPClient. If you are using google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey with NewService instead. (staticcheck)
	service, err := bigquery.New(client)
	                ^
internal/api/handler.go:138:15: SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (staticcheck)
	cn, ok := w.(http.CloseNotifier)
	             ^

NOTE I am not very sure if I'm doing the right thing fixing the last
warning.

Signed-off-by: Kir Kolyshkin <[email protected]>

Author: kolyshkin

cmd/internal/api/handler.go

@@ -135,10 +135,6 @@ func writeResult(res interface{}, w http.ResponseWriter) error {
 }
 
 func streamResults(eventChannel *events.EventChannel, w http.ResponseWriter, r *http.Request, m manager.Manager) error {
-	cn, ok := w.(http.CloseNotifier)
-	if !ok {
-		return errors.New("could not access http.CloseNotifier")
-	}
 	flusher, ok := w.(http.Flusher)
 	if !ok {
 		return errors.New("could not access http.Flusher")
@@ -151,7 +147,7 @@ func streamResults(eventChannel *events.EventChannel, w http.ResponseWriter, r *
 	enc := json.NewEncoder(w)
 	for {
 		select {
-		case <-cn.CloseNotify():
+		case <-r.Context().Done():
 			m.CloseEventChannel(eventChannel.GetWatchId())
 			return nil
 		case ev := <-eventChannel.GetChannel():

cmd/internal/storage/bigquery/client/client.go

@@ -15,6 +15,7 @@
 package client
 
 import (
+	"context"
 	"flag"
 	"fmt"
 	"io/ioutil"
@@ -23,6 +24,7 @@ import (
 	"golang.org/x/oauth2"
 	"golang.org/x/oauth2/jwt"
 	bigquery "google.golang.org/api/bigquery/v2"
+	"google.golang.org/api/option"
 )
 
 var (
@@ -71,7 +73,7 @@ func connect() (*oauth2.Token, *bigquery.Service, error) {
 		PrivateKey: pemBytes,
 		TokenURL:   "https://accounts.google.com/o/oauth2/token",
 	}
-	token, err := jwtConfig.TokenSource(oauth2.NoContext).Token()
+	token, err := jwtConfig.TokenSource(context.Background()).Token()
 	if err != nil {
 		return nil, nil, err
 	}
@@ -88,9 +90,9 @@ func connect() (*oauth2.Token, *bigquery.Service, error) {
 			TokenURL: "https://accounts.google.com/o/oauth2/token",
 		},
 	}
-	client := config.Client(oauth2.NoContext, token)
+	client := config.Client(context.Background(), token)
 
-	service, err := bigquery.New(client)
+	service, err := bigquery.NewService(context.Background(), option.WithHTTPClient(client))
 	if err != nil {
 		fmt.Printf("Failed to create new service: %v\n", err)
 		return nil, nil, err

cmd/internal/storage/statsd/client/client.go

@@ -47,7 +47,7 @@ func (c *Client) Close() error {
 func (c *Client) Send(namespace, containerName, key string, value uint64) error {
 	// only send counter value
 	formatted := fmt.Sprintf("%s.%s.%s:%d|g", namespace, containerName, key, value)
-	_, err := fmt.Fprintf(c.conn, formatted)
+	_, err := fmt.Fprint(c.conn, formatted)
 	if err != nil {
 		return fmt.Errorf("failed to send data %q: %v", formatted, err)
 	}