Skip to content

Commit 9c6fb75

Browse files
authored
Merge pull request #3151 from bobbypage/bump-golang-119
Bump golang to 1.19
2 parents 86b11c6 + 7f999bc commit 9c6fb75

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ jobs:
44
test:
55
strategy:
66
matrix:
7-
go-versions: [1.18, 1.17]
7+
go-versions: [1.19, 1.18]
88
platform: [ubuntu-20.04]
99
environment-variables: [build/config/plain.sh, build/config/libpfm4.sh, build/config/libipmctl.sh]
1010
runs-on: ${{ matrix.platform }}
@@ -30,7 +30,7 @@ jobs:
3030
test-integration:
3131
strategy:
3232
matrix:
33-
go-versions: [1.18, 1.17]
33+
go-versions: [1.19, 1.18]
3434
platform: [ubuntu-20.04]
3535
environment-variables: [build/config/plain.sh, build/config/libpfm4.sh, build/config/libipmctl.sh]
3636
runs-on: ${{ matrix.platform }}

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ docker-%:
7272
@docker build -t cadvisor:$(shell git rev-parse --short HEAD) -f deploy/Dockerfile .
7373

7474
docker-build:
75-
@docker run --rm -w /go/src/github.com/google/cadvisor -v ${PWD}:/go/src/github.com/google/cadvisor golang:1.18 make build
75+
@docker run --rm -w /go/src/github.com/google/cadvisor -v ${PWD}:/go/src/github.com/google/cadvisor golang:1.19 make build
7676

7777
presubmit: # lint : TODO re-enable lint after it works on golang 1.19
7878
@echo ">> checking go mod tidy"

build/integration-in-docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,5 +70,5 @@ GO_FLAGS=${GO_FLAGS:-"-tags=netgo -race"}
7070
PACKAGES=${PACKAGES:-"sudo"}
7171
BUILD_PACKAGES=${BUILD_PACKAGES:-}
7272
CADVISOR_ARGS=${CADVISOR_ARGS:-}
73-
GOLANG_VERSION=${GOLANG_VERSION:-"1.18"}
73+
GOLANG_VERSION=${GOLANG_VERSION:-"1.19"}
7474
run_tests "$GO_FLAGS" "$PACKAGES" "$BUILD_PACKAGES" "$CADVISOR_ARGS"

build/unit-in-container.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ function run_tests() {
4040

4141
GO_FLAGS=${GO_FLAGS:-"-tags=netgo -race"}
4242
BUILD_PACKAGES=${BUILD_PACKAGES:-}
43-
GOLANG_VERSION=${GOLANG_VERSION:-"1.18"}
43+
GOLANG_VERSION=${GOLANG_VERSION:-"1.19"}
4444
run_tests

deploy/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM mirror.gcr.io/library/golang:1.18-alpine3.16 AS build
1+
FROM mirror.gcr.io/library/golang:1.19-alpine3.16 AS build
22

33
# Install build depdencies for all supported arches
44
RUN apk --no-cache add bash build-base cmake device-mapper findutils git \

deploy/canary/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.18
1+
FROM golang:1.19
22
33

44
RUN apt-get update && apt-get install -y git dmsetup && apt-get clean

0 commit comments

Comments
 (0)