Increasing required verbosity level

Author: iwankgb

container/raw/factory.go

@@ -31,7 +31,7 @@ import (
 
 var (
 	DockerOnly             = flag.Bool("docker_only", false, "Only report docker containers in addition to root stats")
-	DisableRootCgroupStats = flag.Bool("disable_root_cgroup_stats", false, "Disable collecting root Cgroup stats")
+	disableRootCgroupStats = flag.Bool("disable_root_cgroup_stats", false, "Disable collecting root Cgroup stats")
 )
 
 type rawFactory struct {

container/raw/handler.go

@@ -227,7 +227,7 @@ func (h *rawContainerHandler) getFsStats(stats *info.ContainerStats) error {
 }
 
 func (h *rawContainerHandler) GetStats() (*info.ContainerStats, error) {
-	if *DisableRootCgroupStats && isRootCgroup(h.name) {
+	if *disableRootCgroupStats && isRootCgroup(h.name) {
 		return nil, nil
 	}
 	stats, err := h.libcontainerHandler.GetStats()

manager/container.go

@@ -33,7 +33,6 @@ import (
 	"github.com/google/cadvisor/cache/memory"
 	"github.com/google/cadvisor/collector"
 	"github.com/google/cadvisor/container"
-	"github.com/google/cadvisor/container/raw"
 	info "github.com/google/cadvisor/info/v1"
 	v2 "github.com/google/cadvisor/info/v2"
 	"github.com/google/cadvisor/stats"
@@ -482,8 +481,8 @@ func (cd *containerData) nextHousekeepingInterval() time.Duration {
 		var empty time.Time
 		stats, err := cd.memoryCache.RecentStats(cd.info.Name, empty, empty, 2)
 		if err != nil {
-			if cd.allowErrorLogging() && !(cd.isRoot() && *raw.DisableRootCgroupStats) {
-				klog.Warningf("Failed to get RecentStats(%q) while determining the next housekeeping: %v", cd.info.Name, err)
+			if cd.allowErrorLogging() {
+				klog.V(4).Infof("Failed to get RecentStats(%q) while determining the next housekeeping: %v", cd.info.Name, err)
 			}
 		} else if len(stats) == 2 {
 			// TODO(vishnuk): Use no processes as a signal.