Skip to content

Commit cf5390b

Browse files
committed
container/libcontainer: unexport Disk* ids
Those are only used within the package and therefore should not be public. Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent 0ab27c2 commit cf5390b

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

container/libcontainer/handler.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -779,14 +779,14 @@ func setCPUStats(s *cgroups.Stats, ret *info.ContainerStats, withPerCPU bool) {
779779
}
780780

781781
func setDiskIoStats(s *cgroups.Stats, ret *info.ContainerStats) {
782-
ret.DiskIo.IoServiceBytes = DiskStatsCopy(s.BlkioStats.IoServiceBytesRecursive)
783-
ret.DiskIo.IoServiced = DiskStatsCopy(s.BlkioStats.IoServicedRecursive)
784-
ret.DiskIo.IoQueued = DiskStatsCopy(s.BlkioStats.IoQueuedRecursive)
785-
ret.DiskIo.Sectors = DiskStatsCopy(s.BlkioStats.SectorsRecursive)
786-
ret.DiskIo.IoServiceTime = DiskStatsCopy(s.BlkioStats.IoServiceTimeRecursive)
787-
ret.DiskIo.IoWaitTime = DiskStatsCopy(s.BlkioStats.IoWaitTimeRecursive)
788-
ret.DiskIo.IoMerged = DiskStatsCopy(s.BlkioStats.IoMergedRecursive)
789-
ret.DiskIo.IoTime = DiskStatsCopy(s.BlkioStats.IoTimeRecursive)
782+
ret.DiskIo.IoServiceBytes = diskStatsCopy(s.BlkioStats.IoServiceBytesRecursive)
783+
ret.DiskIo.IoServiced = diskStatsCopy(s.BlkioStats.IoServicedRecursive)
784+
ret.DiskIo.IoQueued = diskStatsCopy(s.BlkioStats.IoQueuedRecursive)
785+
ret.DiskIo.Sectors = diskStatsCopy(s.BlkioStats.SectorsRecursive)
786+
ret.DiskIo.IoServiceTime = diskStatsCopy(s.BlkioStats.IoServiceTimeRecursive)
787+
ret.DiskIo.IoWaitTime = diskStatsCopy(s.BlkioStats.IoWaitTimeRecursive)
788+
ret.DiskIo.IoMerged = diskStatsCopy(s.BlkioStats.IoMergedRecursive)
789+
ret.DiskIo.IoTime = diskStatsCopy(s.BlkioStats.IoTimeRecursive)
790790
}
791791

792792
func setMemoryStats(s *cgroups.Stats, ret *info.ContainerStats) {

container/libcontainer/helpers.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ var supportedSubsystems map[string]struct{} = map[string]struct{}{
144144
"perf_event": {},
145145
}
146146

147-
func DiskStatsCopy0(major, minor uint64) *info.PerDiskStats {
147+
func diskStatsCopy0(major, minor uint64) *info.PerDiskStats {
148148
disk := info.PerDiskStats{
149149
Major: major,
150150
Minor: minor,
@@ -153,12 +153,12 @@ func DiskStatsCopy0(major, minor uint64) *info.PerDiskStats {
153153
return &disk
154154
}
155155

156-
type DiskKey struct {
156+
type diskKey struct {
157157
Major uint64
158158
Minor uint64
159159
}
160160

161-
func DiskStatsCopy1(diskStat map[DiskKey]*info.PerDiskStats) []info.PerDiskStats {
161+
func diskStatsCopy1(diskStat map[diskKey]*info.PerDiskStats) []info.PerDiskStats {
162162
i := 0
163163
stat := make([]info.PerDiskStats, len(diskStat))
164164
for _, disk := range diskStat {
@@ -168,21 +168,21 @@ func DiskStatsCopy1(diskStat map[DiskKey]*info.PerDiskStats) []info.PerDiskStats
168168
return stat
169169
}
170170

171-
func DiskStatsCopy(blkioStats []cgroups.BlkioStatEntry) (stat []info.PerDiskStats) {
171+
func diskStatsCopy(blkioStats []cgroups.BlkioStatEntry) (stat []info.PerDiskStats) {
172172
if len(blkioStats) == 0 {
173173
return
174174
}
175-
diskStat := make(map[DiskKey]*info.PerDiskStats)
175+
diskStat := make(map[diskKey]*info.PerDiskStats)
176176
for i := range blkioStats {
177177
major := blkioStats[i].Major
178178
minor := blkioStats[i].Minor
179-
key := DiskKey{
179+
key := diskKey{
180180
Major: major,
181181
Minor: minor,
182182
}
183183
diskp, ok := diskStat[key]
184184
if !ok {
185-
diskp = DiskStatsCopy0(major, minor)
185+
diskp = diskStatsCopy0(major, minor)
186186
diskStat[key] = diskp
187187
}
188188
op := blkioStats[i].Op
@@ -191,7 +191,7 @@ func DiskStatsCopy(blkioStats []cgroups.BlkioStatEntry) (stat []info.PerDiskStat
191191
}
192192
diskp.Stats[op] = blkioStats[i].Value
193193
}
194-
return DiskStatsCopy1(diskStat)
194+
return diskStatsCopy1(diskStat)
195195
}
196196

197197
func NewCgroupManager(name string, paths map[string]string) (cgroups.Manager, error) {

0 commit comments

Comments
 (0)