container-test: fix not running unit tests in cmd

So, build/unit-in-container.sh never ran any tests under cmd.

This happened because the $(go list ...) in BUILD_CMD was not escaped,
and therefore the expansion happened before cd. Here is a demo:

	[kir@kir-rhat cadvisor]$ BUILD_CMD="pwd && cd cmd && echo $(pwd)"
	[kir@kir-rhat cadvisor]$ echo $BUILD_CMD
	pwd && cd cmd && echo /home/kir/go/src/github.com/google/cadvisor

The fix would be to escape the $ in $(go list):

	[kir@kir-rhat cadvisor]$ BUILD_CMD="pwd && cd cmd && echo \$(pwd)"
	[kir@kir-rhat cadvisor]$ echo $BUILD_CMD
	pwd && cd cmd && echo $(pwd)
	[kir@kir-rhat cadvisor]$ sh -c "$BUILD_CMD"
	/home/kir/go/src/github.com/google/cadvisor
	/home/kir/go/src/github.com/google/cadvisor/cmd

Yet, it's easier just to reuse the make test target which already has
the exclusion logic. For that to work properly with custom test configs
from ./build/config, we need to export GO_FLAGS env var into container.

While at it, slightly simplify the BUILD_CMD by adding -e to bash, so we
do not have to specify && every time.

Fixes: 74b513b
Signed-off-by: Kir Kolyshkin <[email protected]>

Author: kolyshkin

build/unit-in-container.sh

@@ -14,28 +14,28 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-set -e
+set -ex
 
 if ! CONTAINER_ENGINE=$(command -v docker || command -v podman); then
   echo "Neither docker nor podman found. Exiting."
   exit 1
 fi
 
 function run_tests() {
-  BUILD_CMD="go test $GO_FLAGS $(go list $GO_FLAGS ./... | grep -v 'vendor\|integration' | tr '\n' ' ') && \
-    cd cmd && go test $GO_FLAGS $(go list $GO_FLAGS ./... | grep -v 'vendor\|integration' | tr '\n' ' ')"
+  BUILD_CMD="make test"
   if [ "$BUILD_PACKAGES" != "" ]; then
-    BUILD_CMD="echo 'deb http://deb.debian.org/debian buster-backports main'>/etc/apt/sources.list.d/buster.list && \
-    apt update && \
-    apt install -y -t buster-backports $BUILD_PACKAGES && \
+    BUILD_CMD="echo 'deb http://deb.debian.org/debian buster-backports main'>/etc/apt/sources.list.d/buster.list
+    apt update
+    apt install -y -t buster-backports $BUILD_PACKAGES
     $BUILD_CMD"
   fi
 
   $CONTAINER_ENGINE run --rm \
     -w /go/src/github.com/google/cadvisor \
     -v ${PWD}:/go/src/github.com/google/cadvisor \
+    -e GO_FLAGS \
     golang:${GOLANG_VERSION} \
-    bash -c "$BUILD_CMD"
+    bash -e -c "$BUILD_CMD"
 }
 
 GO_FLAGS=${GO_FLAGS:-"-tags=netgo -race"}