Wait for the 'end' event on stderr and stdout before writing out the messages (#30)

Author: ChadKillingsworth

lib/gulp/index.js

@@ -131,11 +131,28 @@ module.exports = function(initOptions) {
     compilerProcess.stderr.on('data', function (data) {
       stdErrData += data;
     });
-    compilerProcess.on('close', (function (code) {
+
+    Promise.all([
+      new Promise(function(resolve) {
+        compilerProcess.on('close', function(code) {
+          resolve(code);
+        });
+      }),
+      new Promise(function(resolve) {
+        compilerProcess.stdout.on('end', function() {
+          resolve();
+        });
+      }),
+      new Promise(function(resolve) {
+        compilerProcess.stderr.on('end', function() {
+          resolve();
+        });
+      })
+    ]).then((function(results) {
+      var code = results[0];
       // non-zero exit means a compilation error
       if (code !== 0) {
-        this.emit('error', new PluginError(this.PLUGIN_NAME_,
-            'Compilation error: \n\n' + compiler.prependFullCommand(stdErrData)));
+        this.emit('error', new PluginError(this.PLUGIN_NAME_, 'Compilation error'));
       }
 
       // standard error will contain compilation warnings, log those

test/gulp.js

@@ -53,7 +53,7 @@ describe('gulp-google-closure-compiler', function() {
       });
 
       stream.on('error', function (err) {
-        err.message.should.startWith('Compilation error:');
+        err.message.should.startWith('Compilation error');
         done();
       });
       stream.write(fakeFile1);