Skip to content

Commit 0192157

Browse files
justtonytonecopybara-github
authored andcommitted
Expose the symbol names in SourceMapConsumerV3
PiperOrigin-RevId: 485339547
1 parent c144483 commit 0192157

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

src/com/google/debugging/sourcemap/SourceMapConsumerV3.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import java.util.Collection;
3030
import java.util.Collections;
3131
import java.util.LinkedHashMap;
32+
import java.util.List;
3233
import java.util.Map;
3334
import org.jspecify.nullness.Nullable;
3435

@@ -180,6 +181,10 @@ public Collection<String> getOriginalSources() {
180181
return sourcesContent == null ? null : Arrays.asList(sourcesContent);
181182
}
182183

184+
public List<String> getOriginalNames() {
185+
return Arrays.asList(names);
186+
}
187+
183188
@Override
184189
public Collection<OriginalMapping> getReverseMapping(String originalFile,
185190
int line, int column) {

test/com/google/javascript/jscomp/CompilerTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ public void testInputSourceMapInline() {
245245
SourceMapConsumerV3 sourceMap = inputSourceMap.getSourceMap(null);
246246
assertThat(sourceMap.getOriginalSources()).containsExactly("foo.ts");
247247
assertThat(sourceMap.getOriginalSourcesContent()).isNull();
248+
assertThat(sourceMap.getOriginalNames()).isEmpty();
248249
}
249250

250251
private static final String SOURCE_MAP_TEST_CONTENT =
@@ -276,6 +277,7 @@ public void testInputSourceMapInlineContent() {
276277
SourceMapConsumerV3 sourceMap = inputSourceMap.getSourceMap(null);
277278
assertThat(sourceMap.getOriginalSources()).containsExactly("../test/foo.ts");
278279
assertThat(sourceMap.getOriginalSourcesContent()).containsExactly(SOURCE_MAP_TEST_CONTENT);
280+
assertThat(sourceMap.getOriginalNames()).isEmpty();
279281
}
280282

281283
@Test
@@ -297,6 +299,8 @@ public void testResolveRelativeSourceMap() throws Exception {
297299
for (SourceMapInput inputSourceMap : compiler.inputSourceMaps.values()) {
298300
SourceMapConsumerV3 sourceMap = inputSourceMap.getSourceMap(null);
299301
assertThat(sourceMap.getOriginalSources()).containsExactly("foo.ts");
302+
assertThat(sourceMap.getOriginalSourcesContent()).isNull();
303+
assertThat(sourceMap.getOriginalNames()).isEmpty();
300304
}
301305
}
302306

@@ -322,6 +326,8 @@ public void testResolveRelativeDirSourceMap() throws Exception {
322326
for (SourceMapInput inputSourceMap : compiler.inputSourceMaps.values()) {
323327
SourceMapConsumerV3 sourceMap = inputSourceMap.getSourceMap(null);
324328
assertThat(sourceMap.getOriginalSources()).containsExactly("foo.ts");
329+
assertThat(sourceMap.getOriginalSourcesContent()).isNull();
330+
assertThat(sourceMap.getOriginalNames()).isEmpty();
325331
}
326332
}
327333

@@ -398,6 +404,7 @@ public void testApplyInputSourceMaps() throws Exception {
398404
assertThat(mapping.getIdentifier()).isEqualTo("testSymbolName");
399405
assertThat(consumer.getOriginalSources()).containsExactly("input.js", "input.ts");
400406
assertThat(consumer.getOriginalSourcesContent()).isNull();
407+
assertThat(consumer.getOriginalNames()).containsExactly("testSymbolName");
401408
}
402409

403410
@Test
@@ -422,6 +429,7 @@ public void testKeepInputSourceMapsSourcesContent() throws Exception {
422429
consumer.parse(out.toString());
423430
assertThat(consumer.getOriginalSources()).containsExactly("temp/test/foo.ts");
424431
assertThat(consumer.getOriginalSourcesContent()).containsExactly(SOURCE_MAP_TEST_CONTENT);
432+
assertThat(consumer.getOriginalNames()).containsExactly("X", "input", "y", "console", "log");
425433
}
426434

427435
@Test

0 commit comments

Comments
 (0)