Ban use_precompiled_libraries + any dependency management flags

This functionality is currently semi-broken and will sometimes incorrectly prune or order files. The root problem is that our compilations that generate a TypedAST also run module rewriting passes, which breaks the ability of JSCompiler to order files.

PiperOrigin-RevId: 506760290

Author: lauraharker

src/com/google/javascript/jscomp/Compiler.java

@@ -424,6 +424,15 @@ public int size() {
     // If pruning many unused inputs, it's possible that it's faster to regex-parse everything and
     // AST-parse only the non-pruned inputs, rather than just AST-parse everything once.
     this.preferRegexParser = this.preferRegexParser || options.getDependencyOptions().shouldPrune();
+
+    if (options.getMergedPrecompiledLibraries()
+        && options.getDependencyOptions().needsManagement()) {
+      throw new IllegalArgumentException(
+          "Using precompiled libraries (i.e. TypedAST) is incompatible with flags that "
+              + "automatically order/prune dependencies: "
+              + options.getDependencyOptions()
+              + "");
+    }
   }
 
   public void printConfig() {
@@ -548,6 +557,8 @@ public final void initWithTypedAstFilesystem(
     ImmutableSet<SourceFile> files =
         ImmutableSet.<SourceFile>builder().addAll(externs).addAll(sources).build();
 
+    options.setMergedPrecompiledLibraries(true);
+
     this.initOptions(options);
     this.init(externs, sources, options);
     this.initTypedAstFilesystem(files, typedAstListStream, options);
@@ -573,6 +584,8 @@ public void initModulesWithTypedAstFilesystem(
     }
     ImmutableSet<SourceFile> files = filesBuilder.build();
 
+    options.setMergedPrecompiledLibraries(true);
+
     this.initOptions(options);
     this.initModules(externs, modules, options);
     this.initTypedAstFilesystem(files, typedAstListStream, options);
@@ -586,8 +599,6 @@ private void initTypedAstFilesystem(
     checkState(this.typedAstFilesystem == null);
     maybeSetTracker();
 
-    options.setMergedPrecompiledLibraries(true);
-
     this.setLifeCycleStage(LifeCycleStage.COLORS_AND_SIMPLIFIED_JSDOC);
     // To speed up builds that don't run type-based optimizations, skip type deserialization
     boolean deserializeTypes = options.requiresTypesForOptimization();

test/com/google/javascript/jscomp/integration/TypedAstIntegrationTest.java

@@ -19,6 +19,7 @@
 import static com.google.common.truth.Truth.assertThat;
 import static com.google.javascript.jscomp.base.JSCompStrings.lines;
 import static com.google.javascript.rhino.testing.NodeSubject.assertNode;
+import static org.junit.Assert.assertThrows;
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
@@ -28,8 +29,10 @@
 import com.google.javascript.jscomp.CompilerOptions.IncrementalCheckMode;
 import com.google.javascript.jscomp.CompilerOptions.LanguageMode;
 import com.google.javascript.jscomp.CrossChunkMethodMotion;
+import com.google.javascript.jscomp.DependencyOptions;
 import com.google.javascript.jscomp.DiagnosticGroups;
 import com.google.javascript.jscomp.JSChunk;
+import com.google.javascript.jscomp.ModuleIdentifier;
 import com.google.javascript.jscomp.SourceFile;
 import com.google.javascript.jscomp.VariableRenamingPolicy;
 import com.google.javascript.jscomp.WarningLevel;
@@ -73,6 +76,7 @@ public void simpleAlertCall() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -93,6 +97,7 @@ public void alertCallWithCrossLibraryVarReference() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -139,6 +144,7 @@ public void disambiguatesAndDeletesMethodsAcrossLibraries() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
     options.setDisambiguateProperties(true);
 
     Compiler compiler = compileTypedAstShards(options);
@@ -163,6 +169,7 @@ public void disambiguatesAndDeletesMethodsAcrossLibraries_withTranspilation() th
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
     options.setDisambiguateProperties(true);
     options.setLanguageOut(LanguageMode.ECMASCRIPT5);
 
@@ -256,6 +263,7 @@ public void externJSDocPropertiesNotRenamed() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -281,6 +289,7 @@ public void gatherExternProperties() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -313,6 +322,7 @@ public void protectsHiddenSideEffects() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -329,6 +339,7 @@ public void removesRegExpCallsIfSafe() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -348,6 +359,7 @@ public void removesRegExpCallsIfUnsafelyReferenced() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -374,6 +386,7 @@ public void runsJ2clOptimizations() throws IOException {
 
     CompilerOptions options = new CompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
+    options.setDependencyOptions(DependencyOptions.none());
 
     Compiler compiler = compileTypedAstShards(options);
 
@@ -460,6 +473,27 @@ public void testCrossChunkMethodMotion() throws IOException {
         .isEqualTo(expectedRoot);
   }
 
+  @Test
+  public void dependencyModePruningForGoogModules_banned() throws IOException {
+    precompileLibrary(
+        extern(new TestExternsBuilder().addClosureExterns().build()),
+        code("goog.module('keepMe'); const x = 1;"), // input_1
+        code("goog.module('entryPoint'); goog.require('keepMe');"), // input_2
+        code("goog.module('dropMe'); const x = 3;")); // input_3
+
+    CompilerOptions options = new CompilerOptions();
+    options.setDependencyOptions(
+        DependencyOptions.pruneForEntryPoints(
+            ImmutableList.of(ModuleIdentifier.forClosure("entryPoint"))));
+
+    // TODO(b/219588952): if we decide to support this, verify that JSCompiler no longer incorrectly
+    // prunes the 'keepMe' module.
+    // This might be fixable by just removing module rewriting from the 'checks' phase.
+    Exception ex =
+        assertThrows(IllegalArgumentException.class, () -> compileTypedAstShards(options));
+    assertThat(ex).hasMessageThat().contains("mode=PRUNE");
+  }
+
   // use over 'compileTypedAstShards' if you want to validate reported errors or warnings in your
   // @Test case.
   private Compiler compileTypedAstShardsWithoutErrorChecks(CompilerOptions options)