Added public field this support to ClosureCheckModule for false positives.

Before, if a public field was assigned using the `this.property` format, ClosureCheckModule would throw `JSC_GOOG_MODULE_REFERENCES_THIS`. ClosureCheckModule now checks if the assignment is allowed given that the `this` is not inside a Goog module body which is done by updating the hoist scope. The unit tests demonstrate this new support feature for public fields.

PiperOrigin-RevId: 551033593

Author: Closure Team

src/com/google/javascript/jscomp/NodeTraversal.java

@@ -1100,11 +1100,7 @@ private void handleClassMembers(Node n, Node parent) {
           popScope();
           break;
         case MEMBER_FIELD_DEF:
-          pushScope(child);
-
-          traverseBranch(child, n);
-
-          popScope();
+          handleMemberFieldDef(n, child);
           break;
         case BLOCK:
         case MEMBER_FUNCTION_DEF:
@@ -1123,6 +1119,15 @@ private void handleClassMembers(Node n, Node parent) {
     callback.visit(this, n, parent);
   }
 
+  private void handleMemberFieldDef(Node n, Node child) {
+    Node previousHoistScopeRoot = currentHoistScopeRoot;
+    currentHoistScopeRoot = n;
+    pushScope(child);
+    traverseBranch(child, n);
+    popScope();
+    currentHoistScopeRoot = previousHoistScopeRoot;
+  }
+
   private void traverseChildren(Node n) {
     for (Node child = n.getFirstChild(); child != null; ) {
       // child could be replaced, in which case our child node

test/com/google/javascript/jscomp/ClosureCheckModuleTest.java

@@ -66,6 +66,43 @@ protected CompilerOptions getOptions() {
     return options;
   }
 
+  @Test
+  public void testGoogModuleThisInSubclass() {
+    testSame(
+        lines(
+            "goog.module('xyz');",
+            "class Foo {", //
+            "  x = 5;",
+            "}",
+            "class Bar extends Foo {", //
+            "   z = this.x;",
+            "}"));
+  }
+
+  @Test
+  public void testGoogModuleThisOnFields() {
+    // Ensure `this.property` is allowed as an assignment on public fields.
+    testSame(
+        lines(
+            "goog.module('xyz');",
+            "class Foo {", //
+            "  x = 5;",
+            "  y = this.x",
+            "}"));
+  }
+
+  @Test
+  public void testStaticGoogModuleThisOnStaticFields() {
+    // Allow this to be allowed when a field is already declared
+    testSame(
+        lines(
+            "goog.module('math')", //
+            "class Foo {",
+            "  static x = 5;",
+            "  static y = this.x",
+            "}"));
+  }
+
   @Test
   public void testGoogModuleReferencesThis() {
     testError("goog.module('xyz');\nfoo.call(this, 1, 2, 3);", GOOG_MODULE_REFERENCES_THIS);