Skip to content

Commit 68d62fe

Browse files
blicklycopybara-github
authored andcommitted
Allow inlining properties on global this object not defined in externs
PiperOrigin-RevId: 321176244
1 parent 0c34ece commit 68d62fe

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/com/google/javascript/jscomp/InlineProperties.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@ private static class PropertyInfo {
6161
InlineProperties(AbstractCompiler compiler) {
6262
this.compiler = compiler;
6363
this.invalidatingTypes = new InvalidatingTypes.Builder(compiler.getTypeRegistry())
64-
// TODO(sdh): consider allowing inlining properties of global this
65-
// (we already reserve extern'd names, so this should be safe).
66-
.disallowGlobalThis()
6764
// NOTE: Mismatches are less important to this pass than to (dis)ambiguate properties.
6865
// This pass doesn't remove values (it only inlines them when the type is known), so
6966
// it isn't necessary to invalidate due to implicit interface uses.

0 commit comments

Comments
 (0)