Skip to content

Commit 841adae

Browse files
Closure Teamcopybara-github
authored andcommitted
No public description
PiperOrigin-RevId: 852855924
1 parent e1b109c commit 841adae

27 files changed

+38
-38
lines changed

contrib/externs/underscore-1.3.1.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* @fileoverview Externs for Underscore 1.3.1.
1919
*
2020
* TODO: Wrapper objects.
21-
* TODO: _.bind - for some reason this plays up in practice.
21+
* TODO: user - for some reason this plays up in practice.
2222
*
2323
* @see http://documentcloud.github.com/underscore/
2424
* @externs

contrib/externs/underscore-1.5.2.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* @fileoverview Externs for Underscore 1.5.2.
1919
*
2020
* TODO: Wrapper objects.
21-
* TODO: _.bind - for some reason this plays up in practice.
21+
* TODO: user - for some reason this plays up in practice.
2222
*
2323
* @see http://documentcloud.github.com/underscore/
2424
* @externs

src/com/google/javascript/jscomp/AstFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ Node createName(String name, Type type) {
597597
if (lifeCycleStage.isNormalized() && name.startsWith("$jscomp")) {
598598
// $jscomp will always be a constant and needs to be marked that way to satisfy
599599
// the normalization invariants.
600-
// TODO: b/322009741 - Stop depending on lifeCycleStage.isNormalized() and "$jscomp" prefix to
600+
// TODO: user - Stop depending on lifeCycleStage.isNormalized() and "$jscomp" prefix to
601601
// decide constness. The callers must explicitly use `createConstantName` is they need a NAME
602602
// node that's set with IS_CONSTANT_NAME prop.
603603
result.putBooleanProp(Node.IS_CONSTANT_NAME, true);
@@ -614,7 +614,7 @@ Node createConstantName(String name, Type type) {
614614
Node result = IR.name(name);
615615
setJSTypeOrColor(type, result);
616616
if (lifeCycleStage.isNormalized()) {
617-
// TODO: b/322009741 - Stop depending on lifeCycleStage.isNormalized() to decide constness
617+
// TODO: user - Stop depending on lifeCycleStage.isNormalized() to decide constness
618618
result.putBooleanProp(Node.IS_CONSTANT_NAME, true);
619619
}
620620
return result;

src/com/google/javascript/jscomp/AstValidator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ enum TypeInfoValidation {
6464
/** Validate that a SCRIPT's FeatureSet property includes all features if this is enabled. */
6565
private final boolean isScriptFeatureValidationEnabled;
6666

67-
// TODO: varomodt - make this the default.
67+
// TODO: user - make this the default.
6868
/** Validate that all required inlinings were performed. */
6969
private final boolean shouldValidateRequiredInlinings;
7070

@@ -454,7 +454,7 @@ private void validatePseudoExpression(Node n, Token... allowedPseudoexpressions)
454454
private void validateTypeInformation(Node n) {
455455
if (n.getIsInClosureUnawareSubtree()) {
456456
// We don't expect closure-unaware code to have type information.
457-
// TODO: b/321233583 - Maybe this should be a separate validation step, to ensure that nothing
457+
// TODO: user - Maybe this should be a separate validation step, to ensure that nothing
458458
// tries to infer type information where we are mostly unsure of it?
459459

460460
return;
@@ -2128,7 +2128,7 @@ private void validateFeature(Feature feature, Node n) {
21282128
// Closure-unaware code is currently hidden from transpilation passes in the compiler when
21292129
// options.setClosureUnawareMode(Mode.PASS_THROUGH) is enabled, so the AST
21302130
// might still contain features that should have been transpiled.
2131-
// TODO: b/321233583 - Once JSCompiler always transpiles closure-unaware code, remove this
2131+
// TODO: user - Once JSCompiler always transpiles closure-unaware code, remove this
21322132
// early-return to validate that all closure-unaware code is transpiled properly.
21332133
return;
21342134
}

src/com/google/javascript/jscomp/Compiler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1189,7 +1189,7 @@ private void performPostCompilationTasksInternal() {
11891189
runValidityCheck();
11901190
}
11911191

1192-
// TODO: b/421971366 - try removing this. We shouldn't need it as the code printer
1192+
// TODO: user - try removing this. We shouldn't need it as the code printer
11931193
// will already print out @closureUnaware contents.
11941194
ManageClosureUnawareCode.unwrap(this).process(externsRoot, jsRoot);
11951195

src/com/google/javascript/jscomp/CompilerOptions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2562,7 +2562,7 @@ public void setReplaceStringsPlaceholderToken(String replaceStringsPlaceholderTo
25622562
* <p>PASS_THROUGH: they are entirely hidden from the compiler, as if they were an evaled string.
25632563
*
25642564
* <p>SIMPLE_OPTIMIZATIONS_AND_TRANSPILATION: This is *experimental* - we want to support some
2565-
* minimal transpilation & safe optimizations. TODO: b/421971366 - implement this flag.
2565+
* minimal transpilation & safe optimizations. TODO: user - implement this flag.
25662566
*/
25672567
public enum ClosureUnawareMode {
25682568
PASS_THROUGH,
@@ -2810,7 +2810,7 @@ public boolean getInstrumentAsyncContext() {
28102810
* Reflect.construct}. This is correct, but has the disadvantage of pulling in more helper
28112811
* utilities into the compiled output and of the transpiled output being slightly larger.
28122812
*
2813-
* <p>TODO: b/36789413 - always enable the "safe" transpilation.
2813+
* <p>TODO: user - always enable the "safe" transpilation.
28142814
*/
28152815
public enum Es6SubclassTranspilation {
28162816
CONCISE_UNSAFE,

src/com/google/javascript/jscomp/DefaultPassConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ protected PassListBuilder getFinalizations() {
588588
}
589589

590590
if (options.collapseAnonymousFunctions) {
591-
// TODO: b/197349249 - Maybe we should just move this pass after denormalization. It seems
591+
// TODO: user - Maybe we should just move this pass after denormalization. It seems
592592
// weird to convert from function expression to function declaration while we're still
593593
// supposed to be in a normalized state. But it requires testing as perhaps some optimizations
594594
// in that range will get affected if we skip this rewriting.
@@ -1018,7 +1018,7 @@ private PassListBuilder getLateOptimizationPasses() {
10181018
// above or below from accidentally becoming part of the loop.
10191019
passes.maybeAdd(createEmptyPass(PassNames.BEFORE_EARLY_OPTIMIZATION_LOOP));
10201020
passes.addAll(getEarlyOptimizationLoopPasses());
1021-
// TODO(): Remove this early loop or rename the option that enables it
1021+
// TODO():: Remove this early loop or rename the option that enables it
10221022
// to something more appropriate.
10231023
passes.maybeAdd(createEmptyPass(PassNames.AFTER_EARLY_OPTIMIZATION_LOOP));
10241024
}

src/com/google/javascript/jscomp/ErrorManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ default boolean hasHaltingErrors() {
100100
* being used by ConformanceAllowlister to generate allowlist updates (therefore not reported).
101101
* For all violations other violations (except in generated code), this method returns true.
102102
*/
103-
// TODO: b/332922526 - Rename this method and all its overrides to
103+
// TODO: user - Rename this method and all its overrides to
104104
// {@code shouldReportConformanceViolationIgnoringAllowlists} or similar.
105105
default boolean shouldReportConformanceViolation(
106106
Requirement requirement,

src/com/google/javascript/jscomp/Es6NormalizeClasses.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ private void rewriteStaticMembers(NodeTraversal t, ClassRecord record) {
716716
}
717717

718718
// If there are no super references, place all the static initialization code after the class.
719-
// TODO: b/236744850 - Also skip if there are private field refs.
719+
// TODO: user - Also skip if there are private field refs.
720720
if (!NodeUtil.has(
721721
staticInitTempParent,
722722
/* pred= */ Node::isSuper,

src/com/google/javascript/jscomp/Es6RewriteRestAndSpread.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ private void visitRestParam(NodeTraversal t, Node restParam, Node paramList) {
114114
functionBody.addChildToBack(let);
115115
}
116116
NodeUtil.addFeatureToScript(t.getCurrentScript(), Feature.LET_DECLARATIONS, compiler);
117-
// TODO: b/421971366 - we should instead assert that es6/util/restargument was already injected
117+
// TODO: user - we should instead assert that es6/util/restargument was already injected
118118
// before this point, by InjectTranspilationRuntimeLibraries.
119119
compiler
120120
.getRuntimeJsLibManager()

0 commit comments

Comments
 (0)