Delete unused CodingConvention::isInlinableByConvention

PiperOrigin-RevId: 512759603

Author: lauraharker

src/com/google/javascript/jscomp/CodingConvention.java

@@ -239,11 +239,6 @@ public void applySubclassRelationship(
   public void applySingletonGetter(
       NominalTypeBuilder classType, FunctionType getterType);
 
-  /**
-   * @return Whether the function is inlinable by convention.
-   */
-  public boolean isInlinableFunction(Node n);
-
   /**
    * @return the delegate relationship created by the call or null.
    */

src/com/google/javascript/jscomp/CodingConventions.java

@@ -16,8 +16,6 @@
 
 package com.google.javascript.jscomp;
 
-import static com.google.common.base.Preconditions.checkState;
-
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
 import com.google.errorprone.annotations.Immutable;
@@ -200,11 +198,6 @@ public void applySingletonGetter(
       nextConvention.applySingletonGetter(classType, getterType);
     }
 
-    @Override
-    public boolean isInlinableFunction(Node n) {
-      return nextConvention.isInlinableFunction(n);
-    }
-
     @Override
     public DelegateRelationship getDelegateRelationship(Node callNode) {
       return nextConvention.getDelegateRelationship(callNode);
@@ -438,12 +431,6 @@ public void applySingletonGetter(
       // do nothing.
     }
 
-    @Override
-    public boolean isInlinableFunction(Node n) {
-      checkState(n.isFunction(), n);
-      return true;
-    }
-
     @Override
     public DelegateRelationship getDelegateRelationship(Node callNode) {
       return null;

src/com/google/javascript/jscomp/FunctionInjector.java

@@ -207,17 +207,12 @@ boolean doesFunctionMeetMinimumRequirements(final String fnName, Node fnNode) {
     Node block = NodeUtil.getFunctionBody(fnNode);
 
     // Basic restrictions on functions that can be inlined:
-    // 0) The function is inlinable by convention
     // 1) It contains a reference to itself.
     // 2) It uses its parameters indirectly using "arguments" (it isn't
     //    handled yet.
     // 3) It references "eval". Inline a function containing eval can have
     //    large performance implications.
 
-    if (!compiler.getCodingConvention().isInlinableFunction(fnNode)) {
-      return false;
-    }
-
     final String fnRecursionName = fnNode.getFirstChild().getString();
     checkState(fnRecursionName != null);
 

src/com/google/javascript/jscomp/InlineVariables.java

@@ -972,11 +972,6 @@ private boolean isValidInitialization(Reference initialization) {
         checkState(parent.isAssign() && parent.getFirstChild() == initialization.getNode());
       }
 
-      Node n = initialization.getAssignedValue();
-      if (n.isFunction()) {
-        return compiler.getCodingConvention().isInlinableFunction(n);
-      }
-
       return true;
     }