Do not support sourcemappingURLs with a configured directory for TypedAST builds.

Previously, we were serializing the **path** of the sourcemap file on disk as the `sourceMappingURL` in lazyAst.

With this change, we will serialize the **name** of the sourcemap file.

This only affects TypedAST builds.

E.g: We will now serialize `a.js.map` instead of `foo/bar/a.js.map`.

PiperOrigin-RevId: 504935372

Author: rahul-kamat

src/com/google/javascript/jscomp/Compiler.java

@@ -3282,6 +3282,12 @@ public void addInputSourceMap(String sourceFileName, SourceMapInput inputSourceM
     SourceMapInput sourceMapInput = inputSourceMaps.getOrDefault(sourceFileName, null);
     String sourceMappingURL = sourceMapInput != null ? sourceMapInput.getOriginalPath() : null;
     if (sourceMappingURL != null && !sourceMappingURL.endsWith(".inline.map")) {
+      // Set sourceMappingURL as the name of the sourcemap file, not the original location/path of
+      // the sourcemap file on disk. E.g. turn "blaze-out/.../a.js.map" into "a.js.map"
+      sourceMappingURL =
+          sourceMappingURL.contains("/")
+              ? sourceMappingURL.substring(sourceMappingURL.lastIndexOf("/") + 1)
+              : sourceMappingURL;
       return sourceMappingURL;
     }
     return null;

test/com/google/javascript/jscomp/serialization/SerializeAndDeserializeAstTest.java

@@ -414,12 +414,12 @@ public void testSourceMaps() {
             "    }",
             "    return X;",
             "}());");
-    String sourceMapPath = "relativedir/foo.js.map";
-    String sourceMappingURLComment = "//# sourceMappingURL=" + sourceMapPath;
+    String sourceMappingURL = "foo.js.map";
+    String sourceMappingURLComment = "//# sourceMappingURL=" + sourceMappingURL;
     String code = sourceMapTestCode + "\n" + sourceMappingURLComment;
 
     Result result = testAndReturnResult(srcs(code), expected(code));
-    assertThat(result.compiler.getInputSourceMappingURL("testcode")).isEqualTo(sourceMapPath);
+    assertThat(result.compiler.getInputSourceMappingURL("testcode")).isEqualTo(sourceMappingURL);
   }
 
   @Test
@@ -433,8 +433,8 @@ public void testSourceMapsWithoutResolvingSourceMapAnnotations() {
             "    }",
             "    return X;",
             "}());");
-    String sourceMapPath = "relativedir/foo.js.map";
-    String sourceMappingURLComment = "//# sourceMappingURL=" + sourceMapPath;
+    String sourceMappingURL = "foo.js.map";
+    String sourceMappingURLComment = "//# sourceMappingURL=" + sourceMappingURL;
     String code = sourceMapTestCode + "\n" + sourceMappingURLComment;
 
     Result result = testAndReturnResult(srcs(code), expected(code));
@@ -453,14 +453,37 @@ public void testSourceMapsWithoutParsingInlineSourceMaps() {
             "    }",
             "    return X;",
             "}());");
-    String sourceMapPath = "relativedir/foo.js.map";
-    String sourceMappingURLComment = "//# sourceMappingURL=" + sourceMapPath;
+    String sourceMappingURL = "foo.js.map";
+    String sourceMappingURLComment = "//# sourceMappingURL=" + sourceMappingURL;
     String code = sourceMapTestCode + "\n" + sourceMappingURLComment;
 
     Result result = testAndReturnResult(srcs(code), expected(code));
     // Input source map is registered when `parseInlineSourceMaps = false`, but we won't try to
     // parse it as a Base64 encoded source map.
-    assertThat(result.compiler.getInputSourceMappingURL("testcode")).isEqualTo(sourceMapPath);
+    assertThat(result.compiler.getInputSourceMappingURL("testcode")).isEqualTo(sourceMappingURL);
+  }
+
+  @Test
+  public void testConfiguredDirectorySourceMaps() {
+    // We do not allow the TypeScript compiler to set "compilerOptions.sourceRoot" (option to
+    // configure a directory to store
+    // sourcemaps). Sourcemaps (.js.map) files are placed next to the .js files.
+    // This means sourcemap URLs should be the name of the sourcemap file, not a path to the
+    // sourcemap file. If we see a path, we will serialize only the name of the sourcemap file.
+    String sourceMapTestCode =
+        lines(
+            "var X = (function () {",
+            "    function X(input) {",
+            "        this.y = input;",
+            "    }",
+            "    return X;",
+            "}());");
+    String sourceMappingURLPath = "directory/foo.js.map";
+    String sourceMappingURLComment = "//# sourceMappingURL=" + sourceMappingURLPath;
+    String code = sourceMapTestCode + "\n" + sourceMappingURLComment;
+
+    Result result = testAndReturnResult(srcs(code), expected(code));
+    assertThat(result.compiler.getInputSourceMappingURL("testcode")).isEqualTo("foo.js.map");
   }
 
   @Test

test/com/google/javascript/jscomp/serialization/SerializeTypedAstPassTest.java

@@ -435,14 +435,14 @@ public void serializesSourceMappingURL() throws InvalidProtocolBufferException {
             "    return X;",
             "}());");
 
-    String code = sourceMapTestCode + "\n//# sourceMappingURL=relativedir/foo.js.map";
+    String code = sourceMapTestCode + "\n//# sourceMappingURL=foo.js.map";
 
     SerializationResult result = compile(code);
 
     LazyAst lazyAst = result.ast.getCodeAstList().get(0);
     String sourceMappingURL = lazyAst.getSourceMappingUrl();
 
-    assertThat(sourceMappingURL).isEqualTo("relativedir/foo.js.map");
+    assertThat(sourceMappingURL).isEqualTo("foo.js.map");
   }
 
   @Test