Use LinkedHash(Map|Set) to guarantee deterministic iteration order

PiperOrigin-RevId: 514566539

Author: brad4d

src/com/google/javascript/jscomp/ComposeWarningsGuard.java

@@ -25,7 +25,7 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.SortedSet;
@@ -44,7 +44,7 @@ public final class ComposeWarningsGuard extends WarningsGuard {
   private static final long serialVersionUID = 1L;
 
   // The order that the guards were added in.
-  private final Map<WarningsGuard, Integer> orderOfAddition = new HashMap<>();
+  private final Map<WarningsGuard, Integer> orderOfAddition = new LinkedHashMap<>();
   private int numberOfAdds = 0;
 
   private final Comparator<WarningsGuard> guardComparator = new GuardComparator(orderOfAddition);

src/com/google/javascript/jscomp/DiagnosticGroup.java

@@ -19,7 +19,7 @@
 import com.google.common.collect.ImmutableSet;
 import java.io.Serializable;
 import java.util.Arrays;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.Map;
 import org.jspecify.nullness.Nullable;
 
@@ -77,7 +77,7 @@ public DiagnosticGroup(String name, DiagnosticGroup... groups) {
   }
 
   // DiagnosticGroups with only a single DiagnosticType.
-  private static final Map<DiagnosticType, DiagnosticGroup> singletons = new HashMap<>();
+  private static final Map<DiagnosticType, DiagnosticGroup> singletons = new LinkedHashMap<>();
 
   /** Create a diagnostic group that matches only the given type. */
   public static synchronized DiagnosticGroup forType(DiagnosticType type) {