Move reportUntranspilableFeatures pass inside addEarlyOptimizationTranspilation method

The `CompilerTestCase.transpileToEs5` method creates its own PassListBuilder to create and invoke custom transpiler passes. In doing that, it only includes select passes from outside `addEarlyOptimizationTranspilation`.

This change ensures that the `reportUntranspilableFeatures` gets included and executes in that code path also.

PiperOrigin-RevId: 551316236

Author: rishipal

src/com/google/javascript/jscomp/DefaultPassConfig.java

@@ -123,8 +123,6 @@ public DefaultPassConfig(CompilerOptions options) {
   protected PassListBuilder getTranspileOnlyPasses() {
     PassListBuilder passes = new PassListBuilder(options);
 
-    passes.maybeAdd(reportUntranspilableFeatures);
-
     // Certain errors in block-scoped variable declarations will prevent correct transpilation
     passes.maybeAdd(checkVariableReferences);
     passes.maybeAdd(checkVars);
@@ -166,6 +164,9 @@ protected PassListBuilder getTranspileOnlyPasses() {
 
     passes.maybeAdd(injectRuntimeLibraries);
 
+    // NOTE: Any new transpiler passes added outside of
+    // {@code addEarlyOptimizationTranspilationPasses} also need to update
+    // {@code CompilerTestCase.transpileToEs5}
     TranspilationPasses.addEarlyOptimizationTranspilationPasses(passes, options);
 
     // Passes below this point may rely on normalization and must maintain normalization.
@@ -507,7 +508,6 @@ protected PassListBuilder getChecks() {
   protected PassListBuilder getOptimizations() {
     PassListBuilder passes = new PassListBuilder(options);
     if (options.isPropertyRenamingOnlyCompilationMode()) {
-      passes.maybeAdd(reportUntranspilableFeatures);
       TranspilationPasses.addTranspilationRuntimeLibraries(passes);
       passes.maybeAdd(closureProvidesRequires);
       passes.maybeAdd(processDefinesOptimize);
@@ -551,8 +551,6 @@ protected PassListBuilder getOptimizations() {
       passes.maybeAdd(j2clPass);
     }
 
-    passes.maybeAdd(reportUntranspilableFeatures);
-
     TranspilationPasses.addTranspilationRuntimeLibraries(passes);
 
     if (options.rewritePolyfills || options.getIsolatePolyfills()) {
@@ -1535,14 +1533,6 @@ compiler, new GoogleJsMessageIdGenerator(options.tcProjectId)
                       compiler, ImmutableSet.copyOf(compiler.getOptions().forceLibraryInjection)))
           .build();
 
-  private final PassFactory reportUntranspilableFeatures =
-      PassFactory.builder()
-          .setName("reportUntranspilableFeatures")
-          .setInternalFactory(
-              (compiler) ->
-                  new ReportUntranspilableFeatures(compiler, options.getOutputFeatureSet()))
-          .build();
-
   private final PassFactory removeWeakSources =
       PassFactory.builder()
           .setName("removeWeakSources")

src/com/google/javascript/jscomp/TranspilationPasses.java

@@ -64,6 +64,8 @@ public static void addEs6RewriteImportPathPass(PassListBuilder passes) {
   public static void addEarlyOptimizationTranspilationPasses(
       PassListBuilder passes, CompilerOptions options) {
 
+    passes.maybeAdd(reportUntranspilableFeatures);
+
     // Note that we detect feature by feature rather than by yearly languages
     // in order to handle FeatureSet.BROWSER_2020, which is ES2019 without the new RegExp features.
     // However, RegExp features are not transpiled, and this does not imply that we allow arbitrary
@@ -416,6 +418,15 @@ static final PassFactory getEs6RewriteDestructuring(ObjectDestructuringRewriteMo
           .setInternalFactory(RewriteNullishCoalesceOperator::new)
           .build();
 
+  static final PassFactory reportUntranspilableFeatures =
+      PassFactory.builder()
+          .setName("reportUntranspilableFeatures")
+          .setInternalFactory(
+              (compiler) ->
+                  new ReportUntranspilableFeatures(
+                      compiler, compiler.getOptions().getOutputFeatureSet()))
+          .build();
+
   /**
    * @param script The SCRIPT node representing a JS file
    * @return If the file has any features not in {@code supportedFeatures}