Fix TypedScopeCreator crash on goog.provided names assigned in an if block

The root cause was TypedScopeCreator was declaring these names in the block scope but not the global scope, even though goog.provides are all global

PiperOrigin-RevId: 515746418

Author: lauraharker

src/com/google/javascript/jscomp/TypedScopeCreator.java

@@ -1190,13 +1190,13 @@ void defineCatch(Node n) {
           });
     }
 
-    /** Defines an assignment to a name as if it were an actual declaration. */
-    void defineAssignAsIfDeclaration(Node assignment) {
+    /** Defines an assignment to a name as if it were an actual `var` declaration. */
+    void defineAssignAsIfVarDeclaration(Node assignment) {
       JSDocInfo info = assignment.getJSDocInfo();
       Node name = assignment.getFirstChild();
       checkArgument(name.isName(), name);
       Node rvalue = assignment.getSecondChild();
-      defineName(name, rvalue, currentScope, info);
+      defineName(name, rvalue, currentScope.getClosestHoistScope(), info);
     }
 
     /** Defines a variable declared with `var`, `let`, or `const`. */
@@ -3165,7 +3165,7 @@ void visitPostorder(NodeTraversal t, Node n, Node parent) {
           if (firstChild.isGetProp() && firstChild.isQualifiedName()) {
             maybeDeclareQualifiedName(t, n.getJSDocInfo(), firstChild, n, firstChild.getNext());
           } else if (undeclaredNamesForClosure.contains(firstChild)) {
-            defineAssignAsIfDeclaration(n);
+            defineAssignAsIfVarDeclaration(n);
           }
           break;
 

test/com/google/javascript/jscomp/TypedScopeCreatorTest.java

@@ -6155,6 +6155,16 @@ public void testGoogProvide_singleNameWithAtTypeJSDocIsDeclared() {
     assertThat(fooVar).isNotInferred();
   }
 
+  @Test
+  public void testGoogProvide_singleNameAssignedInIfBlock() {
+    processClosurePrimitives = true;
+    testSame(srcs("goog.provide('foo'); if (!foo) { foo = {}; };"));
+
+    TypedVar fooVar = globalScope.getVar("foo");
+    assertThat(fooVar).hasJSTypeThat().toStringIsEqualTo("{}");
+    assertThat(fooVar).isInferred();
+  }
+
   @Test
   public void testGoogProvide_ignoresBlockScopedShadow() {
     processClosurePrimitives = true;