Skip to content

Improve unicode escape in regex #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Improve unicode escape in regex #3656

merged 1 commit into from
Aug 11, 2020

Conversation

HenryRLee
Copy link
Contributor

This PR supports regex Unicode escape in curly brackets format, provided that the 'u' flag presents.

For example:

let x = /\u{01ac}/u;

Also, it extends Unicode up to 0x10FFFF. For example:

let x = /\u{10FFFF}/u;

I believe this PR also fixes issue #3563.

@google-cla google-cla bot added the cla: yes label Aug 8, 2020
@ctjlewis
Copy link
Contributor

ctjlewis commented Aug 9, 2020

Nice work, Henry! Code LGTM.

I actually submitted a couple of Unicode logic PRs myself to try to learn more about the standard - I'd love if you could review one of them for me. See #3645, #3647.

@HenryRLee
Copy link
Contributor Author

Thanks @christiantjl.

I saw your PRs. #3645 looks good to me. When I have time, I will verify the correctness of the Unicode categories in #3647.

@copybara-service copybara-service bot merged commit 114fff4 into google:master Aug 11, 2020
@lauraharker lauraharker mentioned this pull request Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ctjlewis ctjlewis ctjlewis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenryRLee @ctjlewis