Added BaseRenderingContext2D.prototype.roundRect #4111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @h-joo - anything I can do to improve this? |
niloc132
reviewed
Sep 29, 2023
codyebberson
force-pushed
the
cody-roundRect
branch
from
9b3790f to
2a927ad
Compare
|
@niloc132 - thank you for the review I added the function definition to the This now follows the exact same pattern as |
|
Sorry, I'm just a contributor, I don't have any special powers to get patches merged. |
|
@codyebberson I think this can be closed since 638e7c8 added these methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseRenderingContext2D.prototype.roundRect: https://html.spec.whatwg.org/multipage/canvas.html#canvasrenderingcontext2dPath2D.prototype.roundRect: https://html.spec.whatwg.org/multipage/canvas.html#path2d-objectsBoth refer to: https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-roundrect