Skip to content

target_include_directories on line 120 for on lib/CMakeLists.txt would make configuration step failed when this project (clspv_core) is linked by other project. #1513

@Dalmurii

Description

@Dalmurii

Line 120 of lib/CMakeLists.txt is as following:

target_include_directories(${clspv_lib} PUBLIC ${CLSPV_INCLUDE_DIRS})

Currently, I've seen a variable CLSPV_INCLUDE_DIRS containing:

  • Directory include on root directory which SHOULD be public.
  • Directory prefixed on build which SHOULD be private.

This is an brief of fix in my opinion:

# The include directory which SHOULD be public.
target_include_directories(
  ${clspv_lib} INTERFACE
  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include/> # Include directory on build state
  $<INSTALL_INTERFACE:include/> # include directory as installed.
)

# The include directory which SHOULD be private.
target_include_directories(
  ${clspv_lib} PRIVATE
  ${CLSPV_INCLUDE_DIRS}
)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions