Skip to content

Commit 06173d2

Browse files
authored
build_manager: allow remote unpacking when unpacking everything (#4473)
Now that we are lazily checking for fuzzing targets, it makes sense to allow remote unpacking even when unpacking the full archive. Furthermore, it seems that remote unpacking performances are much higher than local unpacking on CF bots, so this might improve overall performances of the build_manager.
1 parent 089d9ef commit 06173d2

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/clusterfuzz/_internal/build_management/build_manager.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -485,12 +485,11 @@ def _open_build_archive(self, base_build_dir: str, build_dir: str,
485485
# if the HTTP URL is compatible with remote unzipping.
486486
allow_unpack_over_http = environment.get_value(
487487
'ALLOW_UNPACK_OVER_HTTP', default_value=False)
488-
can_unzip_over_http = (
489-
allow_unpack_over_http and not self._unpack_everything and
490-
http_build_url and
488+
can_unpack_over_http = (
489+
allow_unpack_over_http and http_build_url and
491490
build_archive.unzip_over_http_compatible(http_build_url))
492491

493-
if not can_unzip_over_http:
492+
if not can_unpack_over_http:
494493
return self._download_and_open_build_archive(base_build_dir, build_dir,
495494
build_url)
496495
# We do not emmit a metric for build download time, if using http

0 commit comments

Comments
 (0)