Skip to content

Commit 0f1c9ab

Browse files
committed
Also update testcase comment on timeout.
1 parent f59ce2b commit 0f1c9ab

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/clusterfuzz/_internal/bot/tasks/utasks/minimize_task.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,7 @@ def utask_main(uworker_input: uworker_msg_pb2.Input): # pylint: disable=no-memb
573573
logs.info('Timed out during main file minimization.')
574574
return uworker_msg_pb2.Output( # pylint: disable=no-member
575575
error_type=uworker_msg_pb2.ErrorType.MINIMIZE_DEADLINE_EXCEEDED, # pylint: disable=no-member
576+
error_message='Timed out during main file minimization.',
576577
minimize_task_output=minimize_task_output)
577578

578579
logs.info('Minimized main file.')
@@ -593,6 +594,7 @@ def utask_main(uworker_input: uworker_msg_pb2.Input): # pylint: disable=no-memb
593594
logs.info('Timed out during file list minimization.')
594595
return uworker_msg_pb2.Output( # pylint: disable=no-member
595596
error_type=uworker_msg_pb2.ErrorType.MINIMIZE_DEADLINE_EXCEEDED, # pylint: disable=no-member
597+
error_message='Timed out during file list minimization.',
596598
minimize_task_output=minimize_task_output)
597599
logs.info('Minimized file list.')
598600
else:
@@ -616,6 +618,7 @@ def utask_main(uworker_input: uworker_msg_pb2.Input): # pylint: disable=no-memb
616618
logs.info('Timed out during resources minimization.')
617619
return uworker_msg_pb2.Output( # pylint: disable=no-member
618620
error_type=uworker_msg_pb2.ErrorType.MINIMIZE_DEADLINE_EXCEEDED, # pylint: disable=no-member
621+
error_message='Timed out during resources minimization.',
619622
minimize_task_output=minimize_task_output)
620623

621624
logs.info('Minimized resources.')
@@ -640,6 +643,7 @@ def utask_main(uworker_input: uworker_msg_pb2.Input): # pylint: disable=no-memb
640643
logs.info('Timed out during arguments minimization.')
641644
return uworker_msg_pb2.Output( # pylint: disable=no-member
642645
error_type=uworker_msg_pb2.ErrorType.MINIMIZE_DEADLINE_EXCEEDED, # pylint: disable=no-member
646+
error_message='Timed out during arguments minimization.',
643647
minimize_task_output=minimize_task_output)
644648

645649
logs.info('Minimized arguments.')
@@ -787,6 +791,8 @@ def handle_minimize_deadline_exceeded(output: uworker_msg_pb2.Output): # pylint
787791
_skip_minimization(testcase,
788792
'Exceeded minimization deadline too many times.')
789793
else:
794+
data_handler.update_testcase_comment(testcase, data_types.TaskState.WIP,
795+
output.error_message + ' Retrying.')
790796
testcase.set_metadata('minimization_deadline_exceeded_attempts',
791797
attempts + 1)
792798
tasks.add_task('minimize', output.uworker_input.testcase_id,

0 commit comments

Comments
 (0)