Fix incorrect setting of archive_state for newly created testcases. (#4173)

Author: oliverchang

src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py

@@ -235,12 +235,13 @@ def __init__(self,
     self.fuzzed_key = None
     self.absolute_path = None
     self.archive_filename = None
+    self.archived = False
 
   @property
   def filename(self):
     return os.path.basename(self.file_path)
 
-  def is_archived(self):
+  def is_uploaded(self):
     """Return true if archive_testcase_in_blobstore(..) was performed."""
     return self.fuzzed_key is not None
 
@@ -249,14 +250,14 @@ def archive_testcase_in_blobstore(self,
     """Calling setup.archive_testcase_and_dependencies_in_gcs(..)
       and hydrate certain attributes. We single out this method because it's
       expensive and we want to do it at the very last minute."""
-    if self.is_archived():
+    if self.is_uploaded():
       return
 
     if upload_url.key:
       # TODO(metzman): Figure out if we need this check and if we can get rid of
       # the archived return value.
       self.fuzzed_key = upload_url.key
-    (_, self.absolute_path, self.archive_filename) = (
+    self.archived, self.absolute_path, self.archive_filename = (
         setup.archive_testcase_and_dependencies_in_gcs(
             self.resource_list, self.file_path, upload_url.url))
 
@@ -275,7 +276,7 @@ def get_error(self):
               (self.crash_state, self.unsymbolized_crash_stacktrace,
                self.crash_stacktrace))
 
-    if self.is_archived() and not self.fuzzed_key:
+    if self.is_uploaded() and not self.fuzzed_key:
       return f'Unable to store testcase in blobstore: {self.crash_state}'
 
     if not self.crash_state or not self.crash_type:
@@ -914,7 +915,7 @@ def create_testcase(group: uworker_msg_pb2.FuzzTaskCrashGroup,
       fuzzer_name=uworker_input.fuzzer_name,
       fully_qualified_fuzzer_name=fully_qualified_fuzzer_name,
       job_type=uworker_input.job_type,
-      archived=bool(crash.fuzzed_key),
+      archived=crash.archived,
       archive_filename=crash.archive_filename,
       http_flag=crash.http_flag,
       gestures=list(crash.gestures),

src/clusterfuzz/_internal/tests/core/bot/tasks/utasks/fuzz_task_test.py

@@ -396,14 +396,14 @@ def test_hydrate_fuzzed_key(self):
     """Test hydrating fuzzed_key."""
     crash = self._test_crash(should_be_ignored=False, security_flag=True)
 
-    self.assertFalse(crash.is_archived())
+    self.assertFalse(crash.is_uploaded())
     self.assertIsNone(crash.get_error())
     self.assertTrue(crash.is_valid())
 
     fuzzed_key = 'fuzzed_key'
     crash.archive_testcase_in_blobstore(
         uworker_msg_pb2.BlobUploadUrl(key=fuzzed_key))
-    self.assertTrue(crash.is_archived())
+    self.assertTrue(crash.is_uploaded())
     self.assertIsNone(crash.get_error())
     self.assertTrue(crash.is_valid())