Skip to content

Commit 70e387b

Browse files
authored
[CLI] remove js_unittest from casp (#5058)
This PR removes the `js_unittest` command and its associated implementation from `casp`. ### Reasoning The `js_unittest` command is deprecated and relies on significantly outdated versions of Chrome and Chromedriver. As noted in [this issue](#2678), the current implementation is unstable/broken. [This PR](#2689) commented out the call to this command a while ago. Fixing this functionality would require a complex migration to the new Chrome/Chromedriver versioning system, which is described [here](https://developer.chrome.com/docs/chromedriver/downloads/version-selection). Since the command is already deprecated, we have decided to remove it rather than investing resources in the upgrade for now. ### Changes Removed the `js_unittest` source file. Removed the command registration and module calls in the main script.
1 parent 8b8b567 commit 70e387b

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

cli/casp/src/casp/commands/js_unittest.py

Lines changed: 0 additions & 22 deletions
This file was deleted.

cli/casp/src/casp/main.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from casp.commands import hi
2222
from casp.commands import init
2323
from casp.commands import integration_tests
24-
from casp.commands import js_unittest
2524
from casp.commands import lint
2625
from casp.commands import package
2726
from casp.commands import py_unittest
@@ -48,7 +47,6 @@ def cli():
4847
cli.add_command(reproduce.cli)
4948
cli.add_command(bootstrap.cli)
5049
cli.add_command(py_unittest.cli)
51-
cli.add_command(js_unittest.cli)
5250
cli.add_command(format_command.cli)
5351
cli.add_command(lint.cli)
5452
cli.add_command(package.cli)

0 commit comments

Comments
 (0)